-
Notifications
You must be signed in to change notification settings - Fork 236
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix root_cache invalidation triggered by config changes
The root_cache plugin assures that no new configuration file in the `config_opts['config_paths']` list is newer than the root_cache cache tarball, otherwise the caches are invalidated. The bug is caused by use of improper set operation (union() doesn't modify the calling object).
- Loading branch information
Showing
2 changed files
with
7 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
The `root_cache` plugin is designed to invalidate the cache tarball anytime the | ||
corresponding Mock configuration changes (any file in the list | ||
`config_opts['config_paths']` changes). This cache invalidation mechanism had | ||
been broken since Mock v3.2 when we rewrote the configuration file loader, and | ||
broke the `config_opts['config_paths']`. The config loader has been fixed now, | ||
and the cache invalidation works again as expected. |