Network wait API support #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
reviewed
Sep 1, 2022
cgwalters
reviewed
Sep 1, 2022
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
2541042 to
ed12240
Compare
RishabhSaini
requested review from
m-blaha and
cgwalters
and removed request for
m-blaha and
cgwalters
cgwalters
reviewed
Sep 6, 2022
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
ed12240 to
73281e6
Compare
cgwalters
reviewed
Sep 6, 2022
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
73281e6 to
6ccecfa
Compare
|
Updated. |
cgwalters
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Thanks! This is looking pretty good to me.
There's still more to do, but I wouldn't think of these things as strictly blocking:
- The code style/indentation does not match the rest of the project. librepo seems to use 4 space indents, and spaces between identifier and parenthesis.
- I think to handle cancellation, we actually need to
g_signal_connect (cancellable, "cancelled", ...)and break out of the mainloop too - Probably useful to think about what tests could look like for this - unit testing here is inherently hard and needs system integration testing
Now I do not have merge rights on this repository.
cgwalters
reviewed
Sep 7, 2022
handle.h: function signature for lr_handle_network_wait handle.c: Added callback function required for GMainEventLoop Adds API support for waiting on network in an event driven manner: This waits for clients network interfaces till the specified time. lr_handle_network_wait(priv->repo_handle, error, timeout_seconds) This parses metalinkurl/baseurl and upon network-available signal, it polls g_network_monitor_can_reach() with the help of GMainEventLoop.
RishabhSaini
force-pushed
the
pr/cos-1694
branch
from
6ccecfa to
756c246
Compare
|
@m-blaha Friendly Ping: Hey, when do you think this can be merged by |
m-blaha
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #259
handle.h: added option for LRO_NETWORK_WAIT and a helper function for handling netowork wait
handle.c: Added callback function required for GMainEventLoop and functionality for option
handle-py.c: Added the case for LRO_NETWORK_WAIT
Adds API support for waiting on network:
This waits for clients network interfaces till the specified time.
lr_handle_setopt(priv->repo_handle, error, LRO_NETWORK_WAIT, seconds)
This parses metalinkurl/baseurl and polls g_network_monitor_can_reach() in an event driven
manner with the help of GMainEventLoop.