[libdnf, actions plugin] Support for action options, option enabled and "plugin.version" variable #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Nov 3, 2023
|
Please change "libdnf5 plugin "actions": doc "plugin.version" var and "enabled" option" commit summary to "[libdnf5 plugin "actions"] doc "plugin.version" var and "enabled" option". All other commits use that format. Or, what I would prefer, is dissolving this commit into commits which bring the features. E.g. "* |
The fourth item in the action definition has been reserved. It is now
used to set additional action options. Options are separated by spaces.
A space within an option can be written using escaping.
One option is now supported - `enabled=<value>`.
Supported values of `value`:
* `1` - action is always enabled
* `host-only` - the action is only enabled for operations on the host
* `installroot-only` - the action is only enabled for operations in
the alternative "installroot"
Action can allways be disabled by commenting out the action line.
"Enabled" can now be set for each action separately. However, to enable actions, the "actions" plugin must be enabled. If "enabled" for the "actions" plugin is set to `host-only`, the action will not be performed for the alternate installroot even if it is enabled for the action.
jrohel
force-pushed
the
feature/libdnf-actions-plugin-ena-ver
branch
from
6dbe292 to
cfd5538
Compare
|
I moved the documentation to commits with the implementation. |
Merged
via the queue into
rpm-software-management:main
with commit Nov 8, 2023
0b121a9
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fourth item in the action definition has been reserved. It is now used to set additional action options. Options are separated by spaces. A space within an option can be written using escaping.
One option is now supported -
enabled=<value>.Supported values of
value:1- action is always enabledhost-only- the action is only enabled for operations on the hostinstallroot-only- the action is only enabled for operations in the alternative "installroot"Action can allways be disabled by commenting out the action line.
PR also adds a new
${plugin.version}substitution. The expression is replaced by the actions plugin version.