Unit tests: Fix problematic nasty hack in run_tests #1950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1947
I found a nasty hack in the code. A pointer to the
CPPUnit::TestCaller
class was cast to a pointer toHackTestCaller
usingreinterpret_cast
. The hack was used to make private members accessible in the original class forLogCaptureListener
.Additionally,
BaseTestCase
has been modified in theLogCaptureListener
class.The code has been rewritten to not need this hack. And the
BaseTestCase
modification was moved tothe
BaseTestCase::setUp
method.Solves: