Fix reporting disk space to be freed on a pure package removal #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test |
There was a bug in testing whether a difference of an installation size and a removal size fits into int64_t. E.g. on a pure package removal, the difference was negative, overflowing resulting unsigned type, leading to a very large positive value, larger than could fit into int64_t. As a result an existing range check failed and no report was printed. This patch fixes it by preventing from a subtraction with a negative rusult. (A fix which would compute the difference before the branching would either loose precision, or decide the branching twice.) Resolves: rpm-software-management#1938
ppisar
force-pushed
the
removal_stats
branch
from
97ece8b to
1584911
Compare
|
I rebased this pull request to the current main HEAD. |
|
@kontura, after a rebase, all tests pass. |
kontura
approved these changes
Dec 16, 2024
|
Thank you |
Merged
via the queue into
rpm-software-management:main
with commit Dec 16, 2024
b533df5
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in testing whether a difference of an installation size and a removal size fits into int64_t. E.g. on a pure package removal, the difference was negative, overflowing resulting unsigned type, leading to a very large positive value, larger than could fit into int64_t. As a result an existing range check failed and no report was printed.
This patch fixes it by preventing from a subtraction with a negative rusult.
(A fix which would compute the difference before the branching would either loose precision, or decide the branching twice.)
Resolves: #1938