Bumb readthedocs ubuntu image version to fix the docs generation #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `ubuntu-22.04` uses version `swig4.0` which fails on C++11 attributes. We have started to use them in: rpm-software-management#1793 and the readthedocs build has been failing since then. Use `24.04` (https://about.readthedocs.com/blog/2024/06/ubuntu-24-04/) because it uses `swig_4.2.0` which at least ignores the attributes. According to the changelog the attributes should be ignored since version 4.1.0: https://www.swig.org/Release/CHANGES ``` 2022-07-07: jmarrec rpm-software-management#1158 #2286 Add basic support for C++11 attributes. These are now crudely ignored by SWIG's parser's tokeniser, which is better than failing with a parse error. ```
|
The failing tests are due to: rpm-software-management/ci-dnf-stack#1601 |
Shouldn't we first resolve that? |
Merged
via the queue into
rpm-software-management:main
with commit Dec 19, 2024
d51f614
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
ubuntu-22.04uses versionswig4.0which fails on C++11 attributes. We have started to use them in: #1793 and the readthedocs build has been failing since then.Use
24.04(https://about.readthedocs.com/blog/2024/06/ubuntu-24-04/) because it usesswig_4.2.0which at least ignores the attributes.According to the changelog the attributes should be ignored since version 4.1.0: https://www.swig.org/Release/CHANGES