Python API: add_new_download return None regression test
#1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
requested changes
Dec 12, 2024
DownloadCallbacks.add_new_download can now return either None or an int. This adds a regression test to check that add_new_download can still return None.
evan-goode
force-pushed
the
evan-goode/add_new_download_None_test
branch
from
fc4854d to
eb120c5
Compare
|
Done and rebased. |
jrohel
approved these changes
Dec 16, 2024
|
Thanks |
Merged
via the queue into
rpm-software-management:main
with commit Dec 16, 2024
b790c1e
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DownloadCallbacks.add_new_downloadcan now return eitherNoneor anint. This adds a regression test to check thatadd_new_downloadcan still returnNone.