Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Use PGP instead of GPG #1917

Merged

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Dec 2, 2024

The public-key technology is called Pretty Good Privacy. GPG is a synonymous for GnuPG, a piece of software which DNF5 does not use.

The public-key technology is called Pretty Good Privacy. GPG is
a synonymous for GnuPG, a piece of software which DNF5 does not use.
Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I verified with rg -g '!dnf5/po/' -i '\bgpg\b' that you got all the relevant user-facing strings.

@evan-goode evan-goode added this pull request to the merge queue Dec 2, 2024
Merged via the queue into rpm-software-management:main with commit 70614fc Dec 2, 2024
15 of 17 checks passed
@pmatilai
Copy link
Member

pmatilai commented Dec 3, 2024

Erm. PGP is the name of a proprietary implementation, just like GnuPG/GPG is the name of one open-source implementation.
OpenPGP is the name of the standard, or technology if you like.

@ppisar
Copy link
Contributor Author

ppisar commented Dec 3, 2024

OpenPGP is a name invented for the purpose of IETF standardization coming years after creation of PGP. See https://www.ietf.org/rfc/rfc1991.html. It's like insisting on calling ODF "Open Document Format for Office Applications".

@pmatilai
Copy link
Member

pmatilai commented Dec 4, 2024

Sure the OpenPGP name was invented later.
It doesn't change the fact that PGP is the name of the proprietary program, still sold even. I wouldn't want us to be associated with THAT.

@pmatilai
Copy link
Member

pmatilai commented Dec 4, 2024

Besides, PGP is a trademard: https://trademarks.justia.com/744/67/pgp-74467812.html

That's one of the reasons people changed their PGP references to GPG back in the day. It wasn't much better, but at least GnuPG folks wouldn't come sue you.

You really don't want to go to using PGP, that's nothing but asking for trouble. There's a proper name for the standard, we should use it.

ppisar added a commit to ppisar/dnf5 that referenced this pull request Dec 5, 2024
"PGP" is a trademark and a name of the original implementation.
Contemporary standard (RFC 4880) calls the technology "OpenPGP"
instead.

This patch changes a documentation, the comments, and the messages. It
keeps function and variable names untouched. Mainly because it would
mean breaking API and ABI.

Related: rpm-software-management#1917
ppisar added a commit to ppisar/dnf5 that referenced this pull request Dec 5, 2024
"PGP" is a trademark and a name of the original implementation.
Contemporary standard (RFC 4880) calls the technology "OpenPGP"
instead.

This patch changes a documentation, the comments, and the messages. It
keeps function and variable names untouched. Mainly because it would
mean breaking API and ABI.

Related: rpm-software-management#1917
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2024
"PGP" is a trademark and a name of the original implementation.
Contemporary standard (RFC 4880) calls the technology "OpenPGP"
instead.

This patch changes a documentation, the comments, and the messages. It
keeps function and variable names untouched. Mainly because it would
mean breaking API and ABI.

Related: #1917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants