-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: While cloning root metadata copy also metalink #1880
Conversation
I think this could solve: https://bugzilla.redhat.com/show_bug.cgi?id=2299337 |
Yes, I believe so. |
I need to check the failing CI test. |
361ec38
to
e2499cc
Compare
The problem was that the PR tried to copy even non-existing metalink file resulting in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the mirrorlist
be handled in the same way?
I have created a couple CI tests for this rpm-software-management/ci-dnf-stack#1597.
I'll take a look on the mirror lists. Thinking about it, this PR is kind of a workaround. We should make sure that remote locations work even without metalink / mirrorlist files. The thing currently is, that repository mirrors are updated during |
Although metalink.xml and mirrorlist are located out of repodata directory, they should be cloned with repository metadata. Without them for example doesn't work packages remote location resolving.
e2499cc
to
e66a12f
Compare
I've added also mirrorlist copying during the clone_root_metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Although metalink.xml is located out of repodata directory, it should be
cloned with repository metadata.
Without correct metalink.xml for example doesn't work package remote
location resolving (because mirrors stored in metalink.xml are unknown).