rpm: Reset RPM log callback upon RpmLogGuard destruction #1870
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses undefined behavior that occurs when the RPM log
callback function is invoked after the RpmLogGuard object has been
destroyed. The issue arises because rpmlogCallbackData retains a
reference to the destroyed object.
The problem manifests during the execution of the builddep plugin command:
trigger the previously set log callback.
points to the destroyed RpmLogGuard.
By resetting the RPM log callback upon RpmLogGuard destruction, this
patch ensures safe and predictable behavior.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2326535
Resolves: #1864