Fix copr chroot specification: replace faulty regex with simpler split #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex `-[^-]*` has multiple matches in a chroot like: `fedora-rawhide-x86_64`, the result of the `regex_replace` is just `fedora`. Replace it with simpler split.
|
Couple tests added here: rpm-software-management/ci-dnf-stack#1594 |
jan-kolarik
approved these changes
Nov 25, 2024
Merged
via the queue into
rpm-software-management:main
with commit Nov 25, 2024
341a75e
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex
-[^-]*has multiple matches in a chroot like:fedora-rawhide-x86_64, the result of theregex_replaceis justfedora.Replace it with simpler split.
After rpm-software-management/ci-dnf-stack#1587 is merged I would also like to add couple CI tests.