When multi_progress_bar finishes print new line automatically
#1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last line of `multi_progress_bar` can look like: `[2/2] Total 100% | 0.0 B/s | 20.0 B | 00m00s` or `http://localhost:43223/api_3/rpmrepo 100% | 72.0 KiB/s | 295.0 B | 00m00s` I don't think any client will ever want to append to that. Instead of it needing to be printed by the client the `multi_progress_bar` automatically ends with a new line. This new line was missing on some places. For example in output of: `dnf copr enable rpmsoftwaremanagement/dnf-nightly ` or `dnf5 rq --repofrompath=test,https://www.not-available-repo.com/ --repo test --setopt=skip_if_unavailable=0` There were also excessive new lines like in: `dnf5 remove htop -y &> out` Closes: rpm-software-management#1792
Mostly to test new lines after `multi_progress_bar`.
|
CI test fix: rpm-software-management/ci-dnf-stack#1582 |
Merged
via the queue into
rpm-software-management:main
with commit Nov 1, 2024
1c5f28c
16 of 20 checks passed
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Dec 4, 2024
Previously the new line was always printed resulting in excessive empty line which was visible for example during the downloading packages phase of an update: ``` [ 1/109] kernel-modules-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 7% [= ] | 781.3 KiB/s | 4.9 MiB | -01m18s [ 2/109] kernel-core-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 8% [== ] | 381.1 KiB/s | 1.5 MiB | -00m45s [ 3/109] kernel-modules-core-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 3% [= ] | 355.8 KiB/s | 1.2 MiB | -01m47s ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ [ 0/109] Total 3% [= ] | 1.5 MiB/s | 7.6 MiB | -02m05s ``` (last line is empty) This was introduced recently in PR rpm-software-management#1805
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Previously the new line was always printed resulting in excessive empty line which was visible for example during the downloading packages phase of an update: ``` [ 1/109] kernel-modules-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 7% [= ] | 781.3 KiB/s | 4.9 MiB | -01m18s [ 2/109] kernel-core-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 8% [== ] | 381.1 KiB/s | 1.5 MiB | -00m45s [ 3/109] kernel-modules-core-0:6.13.0-0.rc1.20241202gite70140ba0d2b.14.fc42.x86_64 3% [= ] | 355.8 KiB/s | 1.2 MiB | -01m47s ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ [ 0/109] Total 3% [= ] | 1.5 MiB/s | 7.6 MiB | -02m05s ``` (last line is empty) This was introduced recently in PR #1805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last line of
multi_progress_barcan look like:[2/2] Total 100% | 0.0 B/s | 20.0 B | 00m00sor
http://localhost:43223/api_3/rpmrepo 100% | 72.0 KiB/s | 295.0 B | 00m00sI don't think any client will ever want to append to that.
Instead of it needing to be printed by the client the
multi_progress_barautomatically ends with a new line.This new line was missing on some places. For example in output of:
dnf copr enable rpmsoftwaremanagement/dnf-nightlyor
dnf5 rq --repofrompath=test,https://www.not-available-repo.com/ --repo test --setopt=skip_if_unavailable=0There were also excessive new lines like in:
dnf5 remove htop -y &> outCloses: #1792