daemon: API to reset the session.base instance #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface was dropped.
- fix return code in case of error - add full_nevra to expected resolve() output
It's currently used to prevent running Goal.do_transaction call multiple times simultaneously.
This change allow us to easily re-create the session goal object in case of the base reset.
For resetting the base held in the session we will need to execute this part of initialization on two places. This patch prevents code duplication.
This call will re-create libdnf5::Base instance stored in the session. As a result, the goal and transaction are reset as well.
m-blaha
force-pushed
the
mblaha/daemon-reset-base
branch
from
9441746 to
d1a90ad
Compare
jan-kolarik
reviewed
Oct 24, 2024
Since resolve() method re-sets transaction, use transaction mutex to prevent running Goal.resolve() if another transaction is running.
jan-kolarik
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
The unit test implementation is deferred to a separate issue as it's not easy and straightforward with the daemon testing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dnf5daemon users to reset their session and re-use it for another transaction.
For: #1653