Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most descriptions for dnf5 --help translatable. #1751

Merged

Conversation

bc-lee
Copy link
Contributor

@bc-lee bc-lee commented Oct 2, 2024

Use _(msgId) in bgettext-lib.h to mark text as eligible for
translation. This will allow translators to translate the short
descriptions of the commands in dnf5 --help. Further changes will be
required to make each command description translatable.

Related: #1736

@bc-lee bc-lee force-pushed the feature/help-description branch 2 times, most recently from cf193f1 to 51bdb81 Compare October 2, 2024 21:13
Copy link
Contributor

@alimirjamali alimirjamali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps that while you are at it, decide if all descriptions should end in full-stop (dot) or not. Currently it is not uniform.

@ppisar ppisar self-assigned this Oct 3, 2024
@ppisar
Copy link
Contributor

ppisar commented Oct 3, 2024

The patch looks good. It seems you tried to mark all short description which are visible in dnf5 --help output. However, some commands are still missing. E.g.:

builddep
changelog
clean

Lee, are going to correct your current pull request? Or should I simply merge it as it is and fix the missing descriptions later?

@bc-lee
Copy link
Contributor Author

bc-lee commented Oct 3, 2024

Lee, are going to correct your current pull request? Or should I simply merge it as it is and fix the missing descriptions later?

I prefer an incremental approach since it would take much longer if we wanted to finish all of the texts related to localization in this PR, and I don't think these changes are necessarily dependent on other PRs.

@ppisar
Copy link
Contributor

ppisar commented Oct 4, 2024

Then please change the commit title. E.g. replace "each command" with "most of the commands".

@bc-lee bc-lee changed the title Make descriptions for each command in dnf5 translatable Make most descriptions for dnf5 --help translatable. Oct 5, 2024
@bc-lee
Copy link
Contributor Author

bc-lee commented Oct 5, 2024

Then please change the commit title. E.g. replace "each command" with "most of the commands".

Done. Could reviewers please check the title and the commit message?

@ppisar
Copy link
Contributor

ppisar commented Oct 7, 2024

You have changed a title of this pull request. I meant changing a title of the git commit message. That's what counts because it will be forever in the git log. Please update the git commit.

Use _(msgId) in bgettext-lib.h to mark text as eligible for
translation. This will allow translators to translate the short
descriptions of the commands in dnf5 --help. Further changes will be
required to make each command description translatable.

Related: rpm-software-management#1736
@bc-lee bc-lee force-pushed the feature/help-description branch from 51bdb81 to 0130265 Compare October 7, 2024 07:10
@bc-lee
Copy link
Contributor Author

bc-lee commented Oct 7, 2024

You have changed a title of this pull request. I meant changing a title of the git commit message. That's what counts because it will be forever in the git log. Please update the git commit.

Before applying the changes to the commit messages, I intentionally updated the title and description of this PR. This is because: 1) Many GitHub-based projects amend multiple commits in a PR, so each commit message is not as important as the PR title and description, and 2) Changing commit messages requires a force push, which isn't recommended for all projects, and I'm not sure if this project (dnf5) allows it.

Nonetheless, I have updated the commit messages as well. Please take a look.

@ppisar ppisar added this pull request to the merge queue Oct 7, 2024
Merged via the queue into rpm-software-management:main with commit 44b412b Oct 7, 2024
16 of 20 checks passed
@bc-lee bc-lee deleted the feature/help-description branch October 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants