-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make most descriptions for dnf5 --help
translatable.
#1751
Make most descriptions for dnf5 --help
translatable.
#1751
Conversation
cf193f1
to
51bdb81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps that while you are at it, decide if all descriptions should end in full-stop (dot) or not. Currently it is not uniform.
The patch looks good. It seems you tried to mark all short description which are visible in builddep Lee, are going to correct your current pull request? Or should I simply merge it as it is and fix the missing descriptions later? |
I prefer an incremental approach since it would take much longer if we wanted to finish all of the texts related to localization in this PR, and I don't think these changes are necessarily dependent on other PRs. |
Then please change the commit title. E.g. replace "each command" with "most of the commands". |
dnf5 --help
translatable.
Done. Could reviewers please check the title and the commit message? |
You have changed a title of this pull request. I meant changing a title of the git commit message. That's what counts because it will be forever in the git log. Please update the git commit. |
Use _(msgId) in bgettext-lib.h to mark text as eligible for translation. This will allow translators to translate the short descriptions of the commands in dnf5 --help. Further changes will be required to make each command description translatable. Related: rpm-software-management#1736
51bdb81
to
0130265
Compare
Before applying the changes to the commit messages, I intentionally updated the title and description of this PR. This is because: 1) Many GitHub-based projects amend multiple commits in a PR, so each commit message is not as important as the PR title and description, and 2) Changing commit messages requires a force push, which isn't recommended for all projects, and I'm not sure if this project ( Nonetheless, I have updated the commit messages as well. Please take a look. |
44b412b
Use
_(msgId)
inbgettext-lib.h
to mark text as eligible fortranslation. This will allow translators to translate the short
descriptions of the commands in
dnf5 --help
. Further changes will berequired to make each command description translatable.
Related: #1736