Add pImpl to the remaining various classes #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kolarik
approved these changes
Apr 4, 2024
|
Nice, LGTM! I briefly went through the list of remaining classes without pimpl and the rest looks fine by me. I believe we've covered everything important. Thanks for working on this! I understand this may have been quite a tedious task. |
jan-kolarik
merged commit 4cff419
into
rpm-software-management:dnf5-5.2.0.0
10 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this could be the last PR for #1025
In my option the rest of the classes are not suitable for pImpl.
Please let me know if we need to add it on some additional place.