Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vars::unset: API method for removing variable #1362

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Vars::unset: API method for removing variable #1362

merged 2 commits into from
Apr 8, 2024

Conversation

jrohel
Copy link
Contributor

@jrohel jrohel commented Apr 2, 2024

Closes #1360

@m-blaha
Copy link
Member

m-blaha commented Apr 2, 2024

Would be nice to also add a unit test for it. Currently, the unit tests only cover reading variables from files and environment.

@m-blaha m-blaha self-assigned this Apr 2, 2024
@jrohel
Copy link
Contributor Author

jrohel commented Apr 8, 2024

@m-blaha

Would be nice to also add a unit test for it. Currently, the unit tests only cover reading variables from files and environment.

Good idea. I added a commit with unit tests.

m-blaha
m-blaha approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha m-blaha added this pull request to the merge queue Apr 8, 2024
Merged via the queue into rpm-software-management:main with commit 863ea91 Apr 8, 2024
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-blaha m-blaha m-blaha approved these changes

Assignees

@m-blaha m-blaha

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: libdnf5::Vars: Missing method for variable removal
2 participants
@jrohel @m-blaha