libdnf5::OptionEnum: remove template, add pImpl #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
reviewed
Mar 27, 2024
jrohel
reviewed
Mar 27, 2024
kontura
force-pushed
the
conf_option_enum
branch
2 times, most recently
from
0c08c78 to
f57940c
Compare
jrohel
reviewed
Mar 28, 2024
The template in both dnf4 and dnf5 is only ever used for the std::string specialization to simplify the code remove it.
kontura
force-pushed
the
conf_option_enum
branch
from
f57940c to
9e52045
Compare
jrohel
merged commit 57f0196
into
rpm-software-management:dnf5-5.2.0.0
8 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #1025
In next PRs I would like to add pImpl also to other
Option* classes.