system-upgrade: backwards-compat offline-{upgrade,distrosync} #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added tests for these commands to this existing ci-dnf-stack PR: rpm-software-management/ci-dnf-stack#1475. Marking as RFR. |
|
@evan-goode rebase the PR please |
m-blaha
requested changes
Mar 27, 2024
Make `dnf5 offline-distrosync` and `dnf5 offline-upgrade` backwards-compatible with DNF 4. There didn't seem to be a way to do this with aliases alone since we need `dnf5 offline-distrosync` and `dnf5 offline-distrosync download` to be aliased to different commands (`dnf5 offline` and `dnf5 distro-sync`, respectively). We also want `dnf5 offline-distrosync --help` to show the help for `dnf5 offline`.
evan-goode
force-pushed
the
evan-goode/offline-transactions
branch
from
be156f9 to
b07f425
Compare
Merged
via the queue into
rpm-software-management:main
with commit Mar 28, 2024
c1565a0
15 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
dnf5 offline-distrosyncanddnf5 offline-upgradebackwards-compatible with DNF 4. There didn't seem to be a way to do this with aliases alone since we needdnf5 offline-distrosyncanddnf5 offline-distrosync downloadto be aliased to different commands (dnf5 offlineanddnf5 distro-sync, respectively). We also wantdnf5 offline-distrosync --helpto show the help fordnf5 offline.Resolves #1343.
Marked draft until I have a ci-dnf-stack PR ready.