Prevent loading plugins for unittests #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Mar 20, 2024
ppisar
approved these changes
Mar 20, 2024
|
@ppisar I've modified the PR. May I ask you to look again to it? |
ppisar
reviewed
Apr 4, 2024
ppisar
reviewed
Apr 4, 2024
ppisar
reviewed
Apr 4, 2024
|
I recommend squashing "Prevent loading plugins for unittests" and "Use a different method for disabling plugins during build" commits into one. |
|
Otherwise, it's good. |
j-mracek
force-pushed
the
tests-without-plugins
branch
from
12a620e to
ede94d3
Compare
It makes functional --no-plugins option in DNF5
j-mracek
force-pushed
the
tests-without-plugins
branch
from
ede94d3 to
741702a
Compare
|
@ppisar Done |
|
@ppisar Thank you for the review |
ppisar
reviewed
Apr 4, 2024
ppisar
reviewed
Apr 4, 2024
ppisar
reviewed
Apr 4, 2024
|
Otherwise, it's good. |
Loading plugins from host system is risky for both sides. Closes: rpm-software-management#1316
j-mracek
force-pushed
the
tests-without-plugins
branch
from
741702a to
b9215c8
Compare
ppisar
approved these changes
Apr 4, 2024
ppisar
merged commit cdf0d3d
into
rpm-software-management:dnf5-5.2.0.0
9 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading plugins from host system is risky for both sides.
Closes: #1316