modules: Report switching module streams #1308
Conversation
pkratoch
force-pushed
the
report-switch-stream-5.2
branch
from
84a2a0e to
511eb65
Compare
|
@pkratoch it seems a rebase is needed. |
libdnf5/base/transaction_module.cpp
Outdated
| std::string module_stream; | ||
| std::string source_stream; | ||
| std::string target_stream; |
There was a problem hiding this comment.
Looking at https://github.com/fedora-modularity/libmodulemd/blob/main/yaml_specs/modulemd_obsoletes_v1.yaml I think it would be possible that a TransactionModule should change to a different module:stream (not only a stream).
What about to use similar approach like TransactionPackage, add something like get_replaces() or get_replaced_by()?
There was a problem hiding this comment.
This is interesting suggestion (good). There is related feature - module obsoletes. Because it was introduced in later state of DNF4 development (shipped only to RHEL9 and Fedora), I am not sure whether module obsoletes are well implemented in software DB.
It would be good to investigate SWDB structure and DNF5 module transaction items whether they support easily those states in way that they could be even reverted.
There was a problem hiding this comment.
Thanks for the suggestion! I am not quite sure how the obsoletes will be implemented, but I modified the TransactionModule similarly to the TransactionPackage. The get_replaced_by() is not needed for stream switching, but I added it, too, for later use for obsoletes.
pkratoch
force-pushed
the
report-switch-stream-5.2
branch
from
511eb65 to
bb2a4de
Compare
|
Thank you |
kontura
merged commit a071fbe
into
rpm-software-management:dnf5-5.2.0.0
Replacement for #1285 , but opened against the dnf5-5.2.0.0 branch.
The tests are still here: rpm-software-management/ci-dnf-stack#1462