Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all libdnf5::Base members to pImpl and remove deprecated #1292

Merged

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Mar 4, 2024

Copy link
Member

@jan-kolarik jan-kolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the two typos, otherwise LGTM.

@jan-kolarik
Copy link
Member

Failing tests are fixed in the enclosed CI PR.

@jan-kolarik jan-kolarik merged commit 56b4d20 into rpm-software-management:dnf5-5.2.0.0 Mar 6, 2024
7 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants