Add pImpl to libdnf5::repo::*
#1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kontura
force-pushed
the
dnf5-5.2.0.0
branch
from
c515b69 to
1577163
Compare
kontura
force-pushed
the
dnf5-5.2.0.0
branch
from
1577163 to
599f7b5
Compare
jrohel
reviewed
Mar 5, 2024
libdnf5/repo/repo_query.cpp
Outdated
| RepoQuery::RepoQuery(const RepoQuery & src) : libdnf5::sack::Query<RepoWeakPtr>(src), p_impl(new Impl(*src.p_impl)) {} | ||
| RepoQuery::RepoQuery(RepoQuery && src) noexcept = default; | ||
|
|
||
| RepoQuery & RepoQuery::operator=(const RepoQuery & src) { |
There was a problem hiding this comment.
Is there a reason to write the same code over and over again?
If instead of std::unique_ptr<Impl> p_impl; we use ImplPtr<Impl> p_impl; (#include "libdnf5/common/impl_ptr.hpp), then we don't have to re-implement copy/move constructor/assignment every time.
Then we can use the default implementation for everything::
RepoQuery::RepoQuery(const RepoQuery & src) = default;
RepoQuery::RepoQuery(RepoQuery && src) noexcept = default;
RepoQuery & RepoQuery::operator=(const RepoQuery & src) = default;
RepoQuery & RepoQuery::operator=(RepoQuery && src) noexcept = default;
There was a problem hiding this comment.
Oh, I wish I had realized that. I have added it basically everywhere. 🤦♂️
Update in this PR.
|
@kontura Thanks for the PR update. |
jrohel
merged commit 612b8ad
into
rpm-software-management:dnf5-5.2.0.0
7 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is into a new dnf5-5.2.0.0 branch to keep the main branch ABI compatible.
For: #1025
I am leaving the interface classes
RepoCallbacksandDownloadCallbacksunmodified.