When limiting installonly pkg handle each provider just once #1261
Conversation
kontura
changed the title
kontura
changed the title
| // if some unused provider is also available we need to mark it ERASE as well. | ||
| auto low = std::lower_bound( | ||
| available_unused_providers.begin(), available_unused_providers.end(), name, name_solvable_id_name_cmp_key); | ||
| while (low != available_unused_providers.end() && (*low)->name == name) { |
There was a problem hiding this comment.
I believe that there is a long standing problem, because we always calculate the order according to name, but may be we should add architecture. Think about x86_64 and i686. Do you think whether it would be worth to add an architecture in account?
There was a problem hiding this comment.
This might sound strange, but handling of available_unused_providers by name is OK (or more secure), but handling of marked_for_install_providers by only name might be an issue.
There was a problem hiding this comment.
I think that would be another change in behavior so I would rather leave that for a different PR.
But I would be interested to know what kind of issues it might cause, perhaps a new github issue to track that would be nice. 👍
kontura
force-pushed
the
custom-overlimit-kernel
branch
from
08d9bd0 to
fc7550c
Compare
libdnf5/rpm/solv/goal_private.cpp
Outdated
| static void same_name_subqueue(libdnf5::solv::RpmPool & pool, Queue * in, Queue * out) { | ||
|
|
||
| /// @brief It takes an `in` Queue which contains packages sorted by name (see `installonly_cmp`). | ||
| /// It selects the first name and upon return the `out` Queue is populated with packages |
There was a problem hiding this comment.
May be I do not understand it correctly. I don't see that it states that it moves all packages (Ids) with the name that is returned from in to out Queue. Or did I overlooked something?
There was a problem hiding this comment.
Hopefully its better now.
It should have identical results but packages are only not marked for ERASE multiple times.
First gather all unique providers of installonly provides and then handle each set of packages (providers) with the same name. Previously the handling was done per provide, this could result repeated handling of a single package if it provided multiple installonly provides. Such as `kernel` and `installonlypkg(kernel)`. This could also lead to problems when multiple versions of installonly pkgs didn't have the same installonly provides. https://bugzilla.redhat.com/show_bug.cgi?id=2263675
kontura
force-pushed
the
custom-overlimit-kernel
branch
from
fc7550c to
1dcd416
Compare
a31446b
First gather all unique providers of installonly provides and then
handle each set of packages (providers) with the same name.
Previously the handling was done per provide, this could result in repeated
handling of a single package if it provided multiple installonly
provides. Such as
kernelandinstallonlypkg(kernel).This could also lead to problems when multiple versions of installonly
pkgs didn't have the same installonly provides.
https://bugzilla.redhat.com/show_bug.cgi?id=2263675
Test: rpm-software-management/ci-dnf-stack#1454