Extend version to four numbers (5.x.y.z) #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
force-pushed
the
version_scheme
branch
from
3ddd3fd to
1b936fb
Compare
kontura
force-pushed
the
dnf5-5.2.0.0
branch
2 times, most recently
from
1577163 to
599f7b5
Compare
The problem is that cmake call to `project()` sets (overrides) the: `PROJECT_VERSION_MAJOR/MINOR/PATCH/TWEAK` with the values provided. https://cmake.org/cmake/help/latest/command/project.html#options This could cause confusion when we want to name some of the variables differently and use differnt order (for example the PROJECT_VERSION_MAJOR variable woudn't be the first).
Dnf5 and libdnf5 call the smallest version number `micro` (on the API as well) unify cmake variable to be the same.
kontura
force-pushed
the
version_scheme
branch
from
1b936fb to
009b209
Compare
ppisar
reviewed
Feb 28, 2024
|
The overall idea and the code look good. However CI fails on cmake invocation: Is it possible to fix it? I'd like see the code buildable and tests passsing before merging this change. That also implies rebasing the target (i.e. merging commits from main branch) first. |
We want to keep the most important version number stable (as a 5 because we are calling the project dnf5) however we also want to mostly adhere to the SEMVER system. Therefore we switch to a 4 number scheme, incrementing the: PRIME version when completely changing API and everything in dnf MAJOR version when you make incompatible API changes MINOR version when you add functionality in a backward compatible manner MICRO version when you make backward compatible bug fixes The PRIME version should hopefully stay as a 5 for the foreseeable future.
kontura
force-pushed
the
version_scheme
branch
2 times, most recently
from
4f6c4b4 to
f09982c
Compare
|
/packit test |
|
Your last commit broke packit: |
|
In an attempt to avoid future conflicts I moved the lines around a bit, it should match: #1296 Anyway the PR should be ready and the builds should work now. |
|
The failing test "dnf/installonly.feature:414 Handle over-limit custom kernel without installonlypkg(kernel) provide" is unrelated. Otherwise, the package builds and the tests are fine. |
ppisar
approved these changes
Mar 6, 2024
ppisar
merged commit e34e0aa
into
rpm-software-management:dnf5-5.2.0.0
9 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this is a breaking change because it is changing a struct in
include/libdnf5/version.hppTherefore I have targeted the
5.2.0.0branch.This means it will not get into rawhide before dnf5 is made default.
I have called the new version number
PRIMEbut I am open to any other naming.