Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pImpl to libdnf5::transaction::* classes #1200

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Add pImpl to libdnf5::transaction::* classes #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd6241b
Add pImpl to `libdnf5::transaction::TransactionItem`
kontura Jan 23, 2024
2c0c739
Add pImpl to `libdnf5::transaction::CompsEnvironment`
kontura Jan 23, 2024
44f80d7
Add pImpl to `libdnf5::transaction::CompsGroup`
kontura Jan 24, 2024
53ce09c
Add pImpl to `libdnf5::transaction::Package`
kontura Jan 24, 2024
29c2aa8
Add pImpl to `libdnf5::transaction::TransactionHistory`
kontura Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 35 additions & 26 deletions include/libdnf5/transaction/comps_environment.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ class CompsEnvironment : public TransactionItem {
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.toStr()
std::string to_string() const { return get_environment_id(); }

CompsEnvironment(const CompsEnvironment & src);
CompsEnvironment & operator=(const CompsEnvironment & src);
CompsEnvironment(CompsEnvironment && src) noexcept;
CompsEnvironment & operator=(CompsEnvironment && src) noexcept;
~CompsEnvironment();

private:
friend Transaction;
friend CompsEnvironmentDbUtils;
Expand All @@ -57,42 +63,42 @@ class CompsEnvironment : public TransactionItem {
/// Get text id of the environment (xml element: `<comps><environment><id>VALUE</id>...`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.getEnvironmentId()
const std::string & get_environment_id() const noexcept { return environment_id; }
const std::string & get_environment_id() const noexcept;

/// Set text id of the environment (xml element: `<comps><environment><id>VALUE</id>...`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.setEnvironmentId(const std::string & value)
void set_environment_id(const std::string & value) { environment_id = value; }
void set_environment_id(const std::string & value);

/// Get name of the environment (xml element: `<comps><environment><name>VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.getName()
const std::string & get_name() const noexcept { return name; }
const std::string & get_name() const noexcept;

/// Set name of the environment (xml element: `<comps><environment><name>VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.setName(const std::string & value)
void set_name(const std::string & value) { name = value; }
void set_name(const std::string & value);

/// Get translated name of the environment in the current locale (xml element: `<comps><environment><name xml:lang="...">VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.getTranslatedName()
const std::string & get_translated_name() const noexcept { return translated_name; }
const std::string & get_translated_name() const noexcept;

/// Set translated name of the environment in the current locale (xml element: `<comps><environment><name xml:lang="...">VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.setTranslatedName(const std::string & value)
void set_translated_name(const std::string & value) { translated_name = value; }
void set_translated_name(const std::string & value);

/// Get types of the packages to be installed with the environment (related xml elements: `<comps><group><packagelist><packagereq type="VALUE" ...>`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.getPackageTypes()
libdnf5::comps::PackageType get_package_types() const noexcept { return package_types; }
libdnf5::comps::PackageType get_package_types() const noexcept;

/// Set types of the packages to be installed with the environment (related xml elements: `<comps><group><packagelist><packagereq type="VALUE" ...>`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.setPackageTypes(libdnf::CompsPackageType value)
void set_package_types(libdnf5::comps::PackageType value) { package_types = value; }
void set_package_types(libdnf5::comps::PackageType value);

/// Create a new CompsEnvironmentGroup object and return a reference to it.
/// The object is owned by the CompsEnvironment.
Expand All @@ -101,71 +107,74 @@ class CompsEnvironment : public TransactionItem {
/// Get list of groups associated with the environment.
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentItem.getGroups()
std::vector<CompsEnvironmentGroup> & get_groups() { return groups; }
std::vector<CompsEnvironmentGroup> & get_groups();

// TODO(dmach): rewrite into TransactionSack.list_installed_environments(); how to deal with references to different transactions? We don't want all of them loaded into memory.
//static std::vector< TransactionItemPtr > getTransactionItemsByPattern(
// libdnf5::utils::SQLite3Ptr conn,
// const std::string &pattern);

std::string environment_id;
std::string name;
std::string translated_name;
libdnf5::comps::PackageType package_types = libdnf5::comps::PackageType::DEFAULT;
std::vector<CompsEnvironmentGroup> groups;
class Impl;
std::unique_ptr<Impl> p_impl;
};


// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:class:CompsEnvironmentGroup
class CompsEnvironmentGroup {
public:
~CompsEnvironmentGroup();
CompsEnvironmentGroup(const CompsEnvironmentGroup & src);
CompsEnvironmentGroup & operator=(const CompsEnvironmentGroup & src);
CompsEnvironmentGroup(CompsEnvironmentGroup && src) noexcept;
CompsEnvironmentGroup & operator=(CompsEnvironmentGroup && src) noexcept;
CompsEnvironmentGroup();

private:
friend Transaction;
friend CompsEnvironmentGroupDbUtils;

/// Get database id (primary key)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.getId()
int64_t get_id() const noexcept { return id; }
int64_t get_id() const noexcept;

/// Set database id (primary key)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.setId(int64_t value)
void set_id(int64_t value) { id = value; }
void set_id(int64_t value);

/// Get groupid of a group associated with a comps environment (xml element: `<comps><environment><grouplist><groupid>VALUE</groupid>`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.getGroupId()
const std::string & get_group_id() const noexcept { return group_id; }
const std::string & get_group_id() const noexcept;

/// Set groupid of a group associated with a comps environment (xml element: `<comps><environment><grouplist><groupid>VALUE</groupid>`)
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.setGroupId(const std::string & value)
void set_group_id(const std::string & value) { group_id = value; }
void set_group_id(const std::string & value);

/// Get a flag that determines if the group was present after the transaction it's associated with has finished.
/// If the group was installed before running the transaction, it's still counted as installed.
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.getInstalled()
bool get_installed() const noexcept { return installed; }
bool get_installed() const noexcept;

/// Set a flag that determines if the group was present after the transaction it's associated with has finished.
/// If the group was installed before running the transaction, it's still counted as installed.
///
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.setInstalled(bool value)
void set_installed(bool value) { installed = value; }
void set_installed(bool value);

// TODO(dmach): this is not entirely clear; investigate and document
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.getGroupType()
libdnf5::comps::PackageType get_group_type() const noexcept { return group_type; }
libdnf5::comps::PackageType get_group_type() const noexcept;

// TODO(dmach): this is not entirely clear; investigate and document
// @replaces libdnf:transaction/CompsEnvironmentItem.hpp:method:CompsEnvironmentGroup.setGroupType(libdnf::CompsPackageType value)
void set_group_type(libdnf5::comps::PackageType value) { group_type = value; }
void set_group_type(libdnf5::comps::PackageType value);

int64_t id = 0;
std::string group_id;
bool installed = false;
libdnf5::comps::PackageType group_type;
class Impl;
std::unique_ptr<Impl> p_impl;
};

} // namespace libdnf5::transaction
Expand Down
61 changes: 35 additions & 26 deletions include/libdnf5/transaction/comps_group.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ class CompsGroup : public TransactionItem {
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.toStr()
std::string to_string() const { return get_group_id(); }

CompsGroup(const CompsGroup & src);
CompsGroup & operator=(const CompsGroup & src);
CompsGroup(CompsGroup && src) noexcept;
CompsGroup & operator=(CompsGroup && src) noexcept;
~CompsGroup();

private:
friend Transaction;
friend CompsGroupPackage;
Expand All @@ -58,42 +64,42 @@ class CompsGroup : public TransactionItem {
/// Get text id of the group (xml element: `<comps><group><id>VALUE</id>...`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.getGroupId()
const std::string & get_group_id() const noexcept { return group_id; }
const std::string & get_group_id() const noexcept;

/// Get text id of the group (xml element: `<comps><group><id>VALUE</id>...`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.setGroupId(const std::string & value)
void set_group_id(const std::string & value) { group_id = value; }
void set_group_id(const std::string & value);

/// Get name of the group (xml element: `<comps><group><name>VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.getName()
const std::string & get_name() const noexcept { return name; }
const std::string & get_name() const noexcept;

/// Set name of the group (xml element: `<comps><group><name>VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.setName(const std::string & value)
void set_name(const std::string & value) { name = value; }
void set_name(const std::string & value);

/// Get translated name of the group in the current locale (xml element: `<comps><group><name xml:lang="...">VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.getTranslatedName()
const std::string & get_translated_name() const noexcept { return translated_name; }
const std::string & get_translated_name() const noexcept;

/// Set translated name of the group in the current locale (xml element: `<comps><group><name xml:lang="...">VALUE</name>...`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.setTranslatedName(const std::string & value)
void set_translated_name(const std::string & value) { translated_name = value; }
void set_translated_name(const std::string & value);

/// Get types of the packages to be installed with the group (related xml elements: `<comps><group><packagelist><packagereq type="VALUE" ...>`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.getPackageTypes()
libdnf5::comps::PackageType get_package_types() const noexcept { return package_types; }
libdnf5::comps::PackageType get_package_types() const noexcept;

/// Set types of the packages to be installed with the group (related xml elements: `<comps><group><packagelist><packagereq type="VALUE" ...>`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.setPackageTypes(libdnf::CompsPackageType value)
void set_package_types(libdnf5::comps::PackageType value) { package_types = value; }
void set_package_types(libdnf5::comps::PackageType value);

/// Create a new CompsGroupPackage object and return a reference to it.
/// The object is owned by the CompsGroup.
Expand All @@ -102,77 +108,80 @@ class CompsGroup : public TransactionItem {
/// Get list of packages associated with the group.
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupItem.getPackages()
std::vector<CompsGroupPackage> & get_packages() { return packages; }
std::vector<CompsGroupPackage> & get_packages();

// TODO(dmach): rewrite into TransactionSack.list_installed_groups(); how to deal with references to different transactions? We don't want all of them loaded into memory.
//static std::vector< TransactionItemPtr > getTransactionItemsByPattern(
// libdnf5::utils::SQLite3Ptr conn,
// const std::string &pattern);

std::string group_id;
std::string name;
std::string translated_name;
libdnf5::comps::PackageType package_types;
std::vector<CompsGroupPackage> packages;
class Impl;
std::unique_ptr<Impl> p_impl;
};


/// CompsGroupPackage represents a package associated with a comps group
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:class:CompsGroupPackage
class CompsGroupPackage {
public:
~CompsGroupPackage();
CompsGroupPackage(const CompsGroupPackage & src);
CompsGroupPackage & operator=(const CompsGroupPackage & src);
CompsGroupPackage(CompsGroupPackage && src) noexcept;
CompsGroupPackage & operator=(CompsGroupPackage && src) noexcept;
CompsGroupPackage();

private:
friend Transaction;
friend CompsGroupPackageDbUtils;

/// Get database id (primary key)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.getId()
int64_t get_id() const noexcept { return id; }
int64_t get_id() const noexcept;

/// Set database id (primary key)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.setId(int64_t value)
void set_id(int64_t value) { id = value; }
void set_id(int64_t value);

/// Get name of a package associated with a comps group (xml element: `<comps><group><packagelist><packagereq>VALUE</packagereq>`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.getName()
const std::string & get_name() const noexcept { return name; }
const std::string & get_name() const noexcept;

/// Set name of a package associated with a comps group (xml element: `<comps><group><packagelist><packagereq>VALUE</packagereq>`)
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.setName(const std::string & value)
void set_name(const std::string & value) { name = value; }
void set_name(const std::string & value);

/// Get a flag that determines if the package was present after the transaction it's associated with has finished.
/// If the package was installed before running the transaction, it's still counted as installed.
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.getInstalled()
bool get_installed() const noexcept { return installed; }
bool get_installed() const noexcept;

/// Set a flag that determines if the package was present after the transaction it's associated with has finished.
/// If the package was installed before running the transaction, it's still counted as installed.
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.setInstalled(bool value)
void set_installed(bool value) { installed = value; }
void set_installed(bool value);

/// Get type of package associated with a comps group (xml element: `<comps><group><packagelist><packagereq type="VALUE" ...>`)
/// See `enum class comps::PackageType` documentation for more details.
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.getPackageType()
libdnf5::comps::PackageType get_package_type() const noexcept { return package_type; }
libdnf5::comps::PackageType get_package_type() const noexcept;

/// Set type of package associated with a comps group (xml element: `<comps><group><packagelist><packagereq type="VALUE" ...>`)
/// See `enum class libdnf5::comps::PackageType` documentation for more details.
///
// @replaces libdnf:transaction/CompsGroupItem.hpp:method:CompsGroupPackage.setPackageType(libdnf::PackageType value)
void set_package_type(libdnf5::comps::PackageType value) { package_type = value; }
void set_package_type(libdnf5::comps::PackageType value);

int64_t id = 0;
std::string name;
bool installed = false;
libdnf5::comps::PackageType package_type = libdnf5::comps::PackageType::DEFAULT;
class Impl;
std::unique_ptr<Impl> p_impl;
};

} // namespace libdnf5::transaction
Expand Down
Loading
Loading