Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pImpl to libdnf5::base::transaction_* classes #1194

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Jan 23, 2024

This includes package, group, environment and module.

This PR is into a new dnf5-5.2.0.0 branch to keep the main branch API compatible.

Another part for: #1025

@kontura kontura force-pushed the pImpl_base_transaction branch from db1c317 to 78054f6 Compare January 23, 2024 09:06
@jan-kolarik jan-kolarik self-assigned this Jan 24, 2024
include/libdnf5/base/transaction_environment.hpp Outdated Show resolved Hide resolved
include/libdnf5/base/transaction_package.hpp Outdated Show resolved Hide resolved
libdnf5/base/transaction_environment.cpp Outdated Show resolved Hide resolved
This includes package, group, environment and module.
@kontura kontura force-pushed the pImpl_base_transaction branch from 78054f6 to fa351cc Compare January 24, 2024 12:22
Copy link
Member

@jan-kolarik jan-kolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jan-kolarik jan-kolarik merged commit 4d1aaf3 into rpm-software-management:dnf5-5.2.0.0 Jan 26, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants