Add pImpl to ModuleItem and remove definitions from header
#1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
commented
Jan 23, 2024
pkratoch
reviewed
Jan 26, 2024
kontura
force-pushed
the
pimpl_module_item
branch
from
3570be2 to
5078ced
Compare
kontura
force-pushed
the
pimpl_module_item
branch
from
5078ced to
a91778c
Compare
pkratoch
merged commit 6e29ae8
into
rpm-software-management:dnf5-5.2.0.0
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is into a new dnf5-5.2.0.0 branch to keep the main branch API compatible.
Another part for: #1025