Add pImpl to ResolveSpecSettings and GoalJobSettings
#1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
force-pushed
the
ABI_pimpl_goal_elems
branch
from
f2e48f6 to
c7a0f07
Compare
jan-kolarik
reviewed
Jan 23, 2024
jan-kolarik
reviewed
Jan 23, 2024
jan-kolarik
reviewed
Jan 23, 2024
jan-kolarik
reviewed
Jan 23, 2024
kontura
force-pushed
the
ABI_pimpl_goal_elems
branch
from
c7a0f07 to
bc77345
Compare
jan-kolarik
merged commit 4859807
into
rpm-software-management:dnf5-5.2.0.0
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is into a new
dnf5-5.2.0.0branch to keep themainbranch API compatible.For: #1025
This is just for
ResolveSpecSettingsandGoalJobSettingsbut it is already a lot of changes so I will make more PR to add the rest of pImpls.