Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url option #1155

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Url option #1155

merged 1 commit into from
Jan 22, 2024

Conversation

derickdiaz
Copy link
Contributor

Fixes #497

Changes get the urls for the package specified by the --url option and returns the first url found as discussed.

@kontura kontura self-assigned this Jan 10, 2024
kontura
kontura requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

dnf5/commands/download/download.cpp Show resolved Hide resolved
dnf5/commands/download/download.cpp Outdated Show resolved Hide resolved
dnf5/commands/download/download.cpp Outdated Show resolved Hide resolved
dnf5/commands/download/download.cpp Outdated Show resolved Hide resolved
kontura
kontura requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the Changed urloption to url commit into the first one?
We prefer to have the history as clean as possible.

dnf5/commands/download/download.cpp Outdated Show resolved Hide resolved
@derickdiaz derickdiaz force-pushed the url-option branch 2 times, most recently from 3b40a73 to 70521e0 Compare January 17, 2024 23:32
kontura
kontura requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good.
One last thing can you remove the Changed urloption to url and reversed assertion condition from the commit message? It doesn't really make sense when the commits are squashed.

@derickdiaz derickdiaz mentioned this pull request Jan 21, 2024
Closed
kontura
kontura approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kontura kontura added this pull request to the merge queue Jan 22, 2024
Merged via the queue into rpm-software-management:main with commit 1461a37 Jan 22, 2024
5 of 9 checks passed
@derickdiaz derickdiaz deleted the url-option branch January 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kontura kontura kontura approved these changes

Assignees

@kontura kontura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dnf download --url
2 participants
@derickdiaz @kontura