modules: Respect defaults when enabling multiple streams of a module #1152
Conversation
|
Related CI tests: rpm-software-management/ci-dnf-stack#1433 |
pkratoch
force-pushed
the
enable-default
branch
from
0fad064 to
c4cdfc4
Compare
libdnf5/module/module_sack.cpp
Outdated
| if (!multiple_stream_modules.empty()) { | ||
| throw EnableMultipleStreamsError( | ||
| M_("Cannot enable multiple streams of one module at the same time. Affected modules: {}"), | ||
| utils::string::join(multiple_stream_modules, ", ")); |
There was a problem hiding this comment.
I believe that in some aspects DNF4 provided a better message.
sudo dnf module enable '*' '*m*'
[sudo] password for jmracek:
Last metadata expiration check: 2:04:24 ago on Wed 17 Jan 2024 12:17:10 PM CET.
Argument '*' matches 5 streams ('10.5', '10.6', '10.7', '10.8', '10.9') of module 'mariadb', but none of the streams are enabled or default
Unable to resolve argument *
Argument '*m*' matches 5 streams ('10.5', '10.6', '10.7', '10.8', '10.9') of module 'mariadb', but none of the streams are enabled or default
Unable to resolve argument *m*
Error: Problems in request:
broken groups or modules: *, *m*
Your code is better because it provides information about all modules with multiple stream for one spec.
sudo dnf5 module enable '*' '*m*'
Updating and loading repositories:
Repositories loaded.
Cannot enable multiple streams of one module at the same time. Affected modules: avocado, avocado-vt, cri-o, mariadb, nextcloud, nginx, perl, perl-DBD-SQLite, perl-libwww-perl, postgresql, swig
The new code does not show information about available streams available streams. It means that user has to run additional command to list all streams for spec.
The critical problem - DNF5 does not show error message for all arguments but only for the first one.
Important problem - if I am not mistaken (I am guessing, following error catch path is quite demanding) - problem is not logged into event log. It means API users will have a difficulty to understand the issue. I am investigation it and I will add additional information in future.
pkratoch
force-pushed
the
enable-default
branch
3 times, most recently
from
d60e8da to
1587ad9
Compare
libdnf5/base/goal.cpp
Outdated
| spec, | ||
| enable_ret.second, | ||
| log_level); | ||
| if (!skip_unavailable) { |
There was a problem hiding this comment.
Are you sure that you want to use skip_unavailable option for situation when request is conflicting? What about skip_broken option.
There was a problem hiding this comment.
I have to test how code handles both situation - speck does not match any module and GoalProblem::MULTIPLE_STREAMS
There was a problem hiding this comment.
After testing - scenario with no match works correctly. Only what works not nicely is a case where GoalProblem::MULTIPLE_STREAMS is triggered and option --skip-unavailable ignores the issue.
There was a problem hiding this comment.
This is a minor issue, not something significant, but if it will be not addressed in the PR, then an issue should be created.
There was a problem hiding this comment.
I added the skip_broken option.
libdnf5/module/module_sack.cpp
Outdated
| auto module_dict = create_module_dict(module_spec_to_query(base, module_spec)); | ||
| // Keep only enabled or default streams if possible | ||
| auto multiple_stream_modules = prune_module_dict(module_dict); | ||
| // If there are any modules with multiple streams to be enabled, throw an error |
There was a problem hiding this comment.
I think that the commend is not valid anymore. May I ask you to update it?
pkratoch
force-pushed
the
enable-default
branch
from
1587ad9 to
bfa81e5
Compare
A new stream of the NoStaticContext module is added and it's also added to defaults. The stream is needed so that there is a module with more than one stream and one default stream. Because of changing the defaults, many tests need to be updated, since the module stream gets enabled whenever there is any enable operation.
pkratoch
force-pushed
the
enable-default
branch
from
bfa81e5 to
2bfbfcc
Compare
|
LGTM |
326e827
Resolves: #1048