Add a method accepting std::string for filter_provides() #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
reviewed
Dec 14, 2023
| @@ -281,6 +281,18 @@ class PackageQuery : public PackageSet { | |||
| /// @since 5.0 | |||
| // | |||
| // @replaces libdnf/sack/query.hpp:method:addFilter(int keyname, int cmp_type, const char *match) - cmp_type = HY_PKG_PROVIDES | |||
| void filter_provides(const std::string & pattern, libdnf5::sack::QueryCmp cmp_type = libdnf5::sack::QueryCmp::EQ) { | |||
There was a problem hiding this comment.
If we go with this version the docs need an update, it says A vector of strings .. but it takes just a string.
j-mracek
force-pushed
the
binding-2
branch
2 times, most recently
from
e3048b5 to
22b8309
Compare
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_provides({"dnf"}) stops to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_name({"dnf"}) and
filter_name({"dnf", "acpi"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_epoch({"0"}) and
filter_epoch({"0", "1"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_version({"0.4"}) and
filter_version({"0.3", "1.0"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_release({"0.4"}) and
filter_release({"0.3", "1.0"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_arch({"noarch"}) and
filter_arch({"src", "nosrc"}) stop to work.
Additionally the commit modifies set for source package. Source packages
have architecture "src" and "nosrc".
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_evr({"5-6"}) and
filter_evr({"6-7", "5-6"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_nevra({"pkg-6-7.arch"}) and
filter_nevra({"pkg-6-7.arch", "pkg-0-7.arch"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_sourcerpm({"pkg-6-7.arch"}) and
filter_sourcerpm({"pkg-6-7.arch", "pkg-0-7.arch"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_url({"<url>"}) and
filter_url({"<url>", "<url>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_summary({"<something>"}) and
filter_summary({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_description({"<something>"}) and
filter_description({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_requires({"<something>"}) and
filter_requires({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_conflicts({"<something>"}) and
filter_conflicts({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_obsoletes({"<something>"}) and
filter_obsoletes({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_recommends({"<something>"}) and
filter_recommends({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_suggests({"<something>"}) and
filter_suggests({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_enhances({"<something>"}) and
filter_enhances({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_supplements({"<something>"}) and
filter_supplements({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_file({"<something>"}) and
filter_file({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_location({"<something>"}) and
filter_location({"<something>", "<something>"}) stop to work.
This is required for Python binding, because when a string argument is
provided, the binding converts it to a vector of characters. The change
might be problematic because filter_repo_id({"<something>"}) and
filter_repo_id({"<something>", "<something>"}) stop to work.
|
@jan-kolarik This PR does not change API, but some project might got an issue with compilation. What do you suggest with this PR? |
Hmm, could you please specify the exact issue with compiling the project after these changes are merged? |
|
The problem is described in commit message: The change might be problematic because filter_arch({"noarch"}) and |
Thanks, I see now. Well, I feel that all changes that could result in breaking the existing client code should be delivered with the major version bump. Therefore, I'd like to bundle this together with other changes in #1091. Is it OK like that? |
|
@j-mracek Could you please target the PR against the https://github.com/rpm-software-management/dnf5/tree/dnf5-5.2.0.0 branch? |
|
Opened - #1216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for Python binding, because when string argument is provided, binding convert it to vector of characters. The change might be problematic because filter_provides({"dnf"}) stop to work.