Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument parser: support repeated positional args, use p_impl, no inline methods #1087

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Argument parser: support repeated positional args, use p_impl, no inline methods #1087

merged 3 commits into from
Mar 21, 2024

Conversation

jrohel
Copy link
Contributor

@jrohel jrohel commented Dec 12, 2023 •
edited
Loading

Breaks the AgumentParser ABI. But it simplifies its maintainability for the future.
Related to #1025

@kontura kontura mentioned this pull request Dec 13, 2023
Closed
10 tasks
@kontura kontura self-assigned this Feb 22, 2024
@jrohel jrohel force-pushed the ArgumentParser_repeat_positional_and_impl branch from 9f4a12f to eb9d2c1 Compare March 14, 2024 17:40
kontura
kontura requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have not yet merged the main and dnf5-5.2.0.0 branches this needs to go to the dnf5-5.2.0.0.

@jrohel jrohel changed the base branch from main to dnf5-5.2.0.0 March 21, 2024 10:43
@jrohel jrohel force-pushed the ArgumentParser_repeat_positional_and_impl branch from eb9d2c1 to 6d664cf Compare March 21, 2024 10:43
@jrohel
Copy link
Contributor Author

jrohel commented Mar 21, 2024

OK. I changed the base branch to dnf5-5.2.0.0 and rebased the PR.

@kontura
Copy link
Contributor

kontura commented Mar 21, 2024

Thank you!

@kontura kontura merged commit c17a371 into rpm-software-management:dnf5-5.2.0.0 Mar 21, 2024
9 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kontura kontura kontura requested changes

Assignees

@kontura kontura

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrohel @kontura