-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing root cache with users #1051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jan-kolarik
force-pushed
the
jkolarik/sharing-root-cache-with-users
branch
from
November 29, 2023 09:59
364e062
to
1175664
Compare
kontura
reviewed
Dec 6, 2023
Also it seems a rebase is needed. |
In order to reuse cached `*.solv` and `*.solvx` files by users, we need to add read permissions.
jan-kolarik
force-pushed
the
jkolarik/sharing-root-cache-with-users
branch
from
December 6, 2023 13:38
1175664
to
07b034e
Compare
kontura
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing repositories within
repo_sack
, check for empty or invalid repository metadata. If either condition is met, attempt to clone the root metadata cache, if available.Solver cache files use the
mkstemp
method and are only readable by the owner. Read attributes have been added to these files.The packages cache is ignored. It is expected that superuser privileges will be required for any command manipulating packages on the system (see #849 or #337).
Additional notes:
/var/cache
, where read permissions are granted to non-owners. However, if a custom directory is specified without read permissions, they are not currently applied to the files. This can be addressed similarly to how it has been implemented for solv files in this PR (see also #789).CI tests: rpm-software-management/ci-dnf-stack#1414.
Closes #1000.