Check serialized temporary files memory is non-empty #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the user report, adding a check after the toml serialization of temporary files memory to make sure the result is not an empty file. Such a file would be not parsable when loading from the disk afterwards.
j-mracek
reviewed
Nov 27, 2023
|
LGTM, only asking about a comment for the test |
Although this scenario is not expected, make sure it is not crashing.
jan-kolarik
force-pushed
the
jkolarik/temp-files-empty-check
branch
from
5102046 to
de29b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the #1001, adding a check after the toml serialization of temporary files memory to make sure the result is not an empty file. Such a file would not be parsable when loading from the disk afterwards.
Closes #1001.