Epoch formatting: set whole seconds precision #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Nov 20, 2023
|
The test failures are unrelated: DNF 5 CI timed out and a Rawhide builds failed because of a new libxml2 (PR #1024). |
There was a change in fmt-10.0.0 which adds support for subsecond precision printing. Given that we want only whole seconds on the output round the time point to `std::chrono::seconds`. Closes: rpm-software-management#1020
kontura
force-pushed
the
seconds_precision
branch
from
596cab7 to
cff0d4e
Compare
|
Updated and rebased to fix the libmlx2 problem. |
|
There is a new failure in testing-farm:fedora-rawhide-x86_64 regarding importing PGP subkeys ("Policy rejects F87F747B8C608731: No binding signature at time 2023-11-20T13:54:38Z"). That's unrelated and probably caused by a time race (e.g. the key is signed in the same second when it is used). |
ppisar
approved these changes
Nov 20, 2023
Merged
via the queue into
rpm-software-management:main
with commit Nov 20, 2023
74696a2
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in fmt-10.0.0 which adds support for sub-second precision printing.
Given that we want only whole seconds on the output round the time point to
std::chrono::seconds.Closes: #1020