Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use rpmlint pre-commit #1015

Merged
merged 1 commit into from
Nov 14, 2023
Merged

use rpmlint pre-commit #1015

merged 1 commit into from
Nov 14, 2023

Conversation

inknos
Copy link
Collaborator

@inknos inknos commented Nov 14, 2023

Closes #1014

@ppisar ppisar self-assigned this Nov 14, 2023
ppisar
ppisar approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is reasonable. It replaces an intermediary git repository installing an rpmlint Python module from Python Index with using rpmlint directly from upstream.

@ppisar
Copy link
Contributor

ppisar commented Nov 14, 2023

The test failure is about disappearing coloring an output. Only in Fedora ≥ 39. This failure seems unrelated.

@ppisar ppisar added this pull request to the merge queue Nov 14, 2023
Merged via the queue into rpm-software-management:main with commit 2d77952 Nov 14, 2023
13 of 15 checks passed
@inknos inknos deleted the update-rpmlint-pre-commit-hooks branch November 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisar ppisar ppisar approved these changes

Assignees

@ppisar ppisar

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve rpmlint checks in PRs
2 participants
@inknos @ppisar