versionlock: Remove "version" from filtering keys

The functionality is covered by "evr" filter and this way we can avoid confusion about packages with the same versions, but different epochs.
rpm-software-management · Jan 9, 2024 · c14e9fd · c14e9fd
1 parent fb2219e
commit c14e9fd
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/libdnf5/rpm/package_sack.cpp b/libdnf5/rpm/package_sack.cpp
@@ -121,9 +121,6 @@ void PackageSack::Impl::load_versionlock_excludes() {
                         std::vector<long unsigned int>{std::stoul(vl_condition.get_value())},
                         vl_condition.get_comparator());
                     break;
-                case VersionlockCondition::Keys::VERSION:
-                    pkg_query.filter_version({vl_condition.get_value()}, vl_condition.get_comparator());
-                    break;
                 case VersionlockCondition::Keys::EVR:
                     pkg_query.filter_evr({vl_condition.get_value()}, vl_condition.get_comparator());
                     break;

diff --git a/libdnf5/rpm/versionlock_config.cpp b/libdnf5/rpm/versionlock_config.cpp
@@ -109,8 +109,6 @@ VersionlockCondition::VersionlockCondition(
     // check that condition key is present and valid
     if (key_str == "epoch") {
         key = Keys::EPOCH;
-    } else if (key_str == "version") {
-        key = Keys::VERSION;
     } else if (key_str == "evr") {
         key = Keys::EVR;
     } else if (key_str == "arch") {

diff --git a/libdnf5/rpm/versionlock_config.hpp b/libdnf5/rpm/versionlock_config.hpp
@@ -32,7 +32,7 @@ namespace libdnf5::rpm {
 
 class VersionlockCondition {
 public:
-    enum class Keys { EPOCH, VERSION, EVR, ARCH };
+    enum class Keys { EPOCH, EVR, ARCH };
 
     VersionlockCondition(const std::string & key_str, const std::string & comparator_str, const std::string & value);