Skip to content

Commit

Permalink
Add a hint to call base.setup() prior loading repositories
Browse files Browse the repository at this point in the history
The oposit order might lead to incomplete substitotions of repository
configurations

Closes: #1374
  • Loading branch information
j-mracek authored and ppisar committed Apr 5, 2024
1 parent 5891145 commit bc2ad3f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions include/libdnf5/base/base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ class Base {
/// configuration of protected_packages (glob:).
/// To prevent differences between configuration and internal Base settings, following configurations
/// will be locked: installroot, varsdir.
/// The method is supposed to be called after configuration is updated, application plugins applied
/// The method is supposed to be called after configuration and vars are updated, application plugins applied
/// their pre configuration modification in configuration, but before repositories are loaded or any Package
/// or Advisory query created.
/// or Advisory query created. The method is recommended to be called before loading repositories, because
/// not all variables for substitutions might be available. Caution - modification of vars after this call
/// might be problematic, because architecture is already fixed for our solver.
/// Calling the method for the second time result in throwing an exception
void setup();

Expand Down

0 comments on commit bc2ad3f

Please sign in to comment.