Use new overload of update_and_load_enabled_repos(...)

It allows hiding of `libdnf5::repo::Repo::load()`. Also simplifies handling of which repos to load in dnf5 context.
rpm-software-management · Mar 26, 2024 · 0bc9975 · 0bc9975
1 parent a3e7418
commit 0bc9975
Show file tree

Hide file tree

Showing 40 changed files with 89 additions and 121 deletions.
diff --git a/dnf5-plugins/automatic_plugin/automatic.cpp b/dnf5-plugins/automatic_plugin/automatic.cpp
@@ -306,10 +306,9 @@ void AutomaticCommand::pre_configure() {
 
 void AutomaticCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
     context.update_repo_metadata_from_advisory_options(
         {}, config_automatic.config_commands.upgrade_type.get_value() == "security", false, false, false, {}, {}, {});
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 
     wait_for_network();
 }

diff --git a/dnf5-plugins/builddep_plugin/builddep.cpp b/dnf5-plugins/builddep_plugin/builddep.cpp
@@ -96,8 +96,7 @@ void BuildDepCommand::configure() {
     }
 
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void BuildDepCommand::parse_builddep_specs(int specs_count, const char * const specs[]) {

diff --git a/dnf5-plugins/changelog_plugin/changelog.cpp b/dnf5-plugins/changelog_plugin/changelog.cpp
@@ -108,8 +108,7 @@ void ChangelogCommand::set_argument_parser() {
 
 void ChangelogCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add(
         libdnf5::Option::Priority::RUNTIME, libdnf5::OPTIONAL_METADATA_TYPES);
 }

diff --git a/dnf5-plugins/needs_restarting_plugin/needs_restarting.cpp b/dnf5-plugins/needs_restarting_plugin/needs_restarting.cpp
@@ -78,9 +78,8 @@ void NeedsRestartingCommand::set_argument_parser() {
 
 void NeedsRestartingCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
 
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 
     const std::set<std::string> metadata_types{libdnf5::METADATA_TYPE_FILELISTS, libdnf5::METADATA_TYPE_UPDATEINFO};
     context.base.get_config().get_optional_metadata_types_option().add(

diff --git a/dnf5-plugins/repoclosure_plugin/repoclosure.cpp b/dnf5-plugins/repoclosure_plugin/repoclosure.cpp
@@ -97,11 +97,10 @@ void RepoclosureCommand::set_argument_parser() {
 
 void RepoclosureCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(false);
     // filelists needed because there are packages in repos with file requirements
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_FILELISTS);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE});
 }
 
 void RepoclosureCommand::run() {

diff --git a/dnf5/commands/advisory/advisory_subcommand.cpp b/dnf5/commands/advisory/advisory_subcommand.cpp
@@ -72,8 +72,7 @@ void AdvisorySubCommand::add_running_kernel_packages(libdnf5::Base & base, libdn
 
 void AdvisorySubCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_UPDATEINFO);
 }

diff --git a/dnf5/commands/autoremove/autoremove.cpp b/dnf5/commands/autoremove/autoremove.cpp
@@ -39,8 +39,7 @@ void AutoremoveCommand::set_argument_parser() {
 
 void AutoremoveCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::NONE);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void AutoremoveCommand::run() {

diff --git a/dnf5/commands/check-upgrade/check-upgrade.cpp b/dnf5/commands/check-upgrade/check-upgrade.cpp
@@ -80,8 +80,7 @@ void CheckUpgradeCommand::set_argument_parser() {
 void CheckUpgradeCommand::configure() {
     auto & context = get_context();
     context.update_repo_metadata_from_specs(pkg_specs);
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     if (changelogs->get_value()) {
         context.base.get_config().get_optional_metadata_types_option().add(
             libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_OTHER);

diff --git a/dnf5/commands/distro-sync/distro-sync.cpp b/dnf5/commands/distro-sync/distro-sync.cpp
@@ -56,8 +56,7 @@ void DistroSyncCommand::set_argument_parser() {
 
 void DistroSyncCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void DistroSyncCommand::run() {

diff --git a/dnf5/commands/downgrade/downgrade.cpp b/dnf5/commands/downgrade/downgrade.cpp
@@ -60,8 +60,7 @@ void DowngradeCommand::set_argument_parser() {
 
 void DowngradeCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void DowngradeCommand::run() {

diff --git a/dnf5/commands/download/download.cpp b/dnf5/commands/download/download.cpp
@@ -164,22 +164,22 @@ void DownloadCommand::configure() {
         pkg_specs.push_back(option->get_value());
     }
 
+    std::vector<libdnf5::repo::Repo::Type> which_repos_to_load = {libdnf5::repo::Repo::Type::AVAILABLE};
+
     context.update_repo_metadata_from_specs(pkg_specs);
     if (resolve_option->get_value() && !alldeps_option->get_value()) {
-        context.set_load_system_repo(true);
+        which_repos_to_load.push_back(libdnf5::repo::Repo::Type::SYSTEM);
     } else if (!resolve_option->get_value() && alldeps_option->get_value()) {
         throw libdnf5::cli::ArgumentParserMissingDependentArgumentError(
             //TODO(jrohel): Add support for requiring an argument by another argument in ArgumentParser?
             M_("Option \"--alldeps\" should be used with \"--resolve\""));
-    } else {
-        context.set_load_system_repo(false);
     }
 
     if (srpm_option->get_value()) {
         context.base.get_repo_sack()->enable_source_repos();
     }
 
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos(which_repos_to_load);
     // Default destination for downloaded rpms is the current directory
     context.base.get_config().get_destdir_option().set(libdnf5::Option::Priority::PLUGINDEFAULT, ".");
 }

diff --git a/dnf5/commands/environment/environment_info.cpp b/dnf5/commands/environment/environment_info.cpp
@@ -43,8 +43,7 @@ void EnvironmentInfoCommand::set_argument_parser() {
 
 void EnvironmentInfoCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_COMPS);
 }

diff --git a/dnf5/commands/environment/environment_list.cpp b/dnf5/commands/environment/environment_list.cpp
@@ -41,8 +41,7 @@ void EnvironmentListCommand::set_argument_parser() {
 
 void EnvironmentListCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_COMPS);
 }

diff --git a/dnf5/commands/group/group_install.cpp b/dnf5/commands/group/group_install.cpp
@@ -47,8 +47,7 @@ void GroupInstallCommand::set_argument_parser() {
 
 void GroupInstallCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_COMPS);
 }

diff --git a/dnf5/commands/group/group_list.cpp b/dnf5/commands/group/group_list.cpp
@@ -43,8 +43,7 @@ void GroupListCommand::set_argument_parser() {
 
 void GroupListCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_COMPS);
 }

diff --git a/dnf5/commands/group/group_remove.cpp b/dnf5/commands/group/group_remove.cpp
@@ -39,8 +39,7 @@ void GroupRemoveCommand::set_argument_parser() {
 
 void GroupRemoveCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_COMPS);
 }

diff --git a/dnf5/commands/group/group_upgrade.cpp b/dnf5/commands/group/group_upgrade.cpp
@@ -43,8 +43,7 @@ void GroupUpgradeCommand::set_argument_parser() {
 
 void GroupUpgradeCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_COMPS);
 }

diff --git a/dnf5/commands/install/install.cpp b/dnf5/commands/install/install.cpp
@@ -72,7 +72,6 @@ void InstallCommand::set_argument_parser() {
 void InstallCommand::configure() {
     auto & context = get_context();
     context.update_repo_metadata_from_specs(pkg_specs);
-    context.set_load_system_repo(true);
     context.update_repo_metadata_from_advisory_options(
         advisory_name->get_value(),
         advisory_security->get_value(),
@@ -83,7 +82,7 @@ void InstallCommand::configure() {
         advisory_bz->get_value(),
         advisory_cve->get_value());
 
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void InstallCommand::run() {

diff --git a/dnf5/commands/leaves/leaves.cpp b/dnf5/commands/leaves/leaves.cpp
@@ -54,8 +54,7 @@ in the group is preceded by a '-' character.)");
 
 void LeavesCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::NONE);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void LeavesCommand::run() {

diff --git a/dnf5/commands/list/list.cpp b/dnf5/commands/list/list.cpp
@@ -109,12 +109,12 @@ void ListCommand::set_argument_parser() {
 void ListCommand::configure() {
     // TODO(mblaha): do not force expired metadata sync if not explicitly required
     pkg_narrow = PkgNarrow::ALL;
-    Context::LoadAvailableRepos load_available = Context::LoadAvailableRepos::ENABLED;
-    bool load_system = true;
+    std::vector<libdnf5::repo::Repo::Type> which_repos_to_load = {libdnf5::repo::Repo::Type::AVAILABLE};
+
     if (available->get_value()) {
         pkg_narrow = PkgNarrow::AVAILABLE;
     } else if (installed->get_value()) {
-        load_available = Context::LoadAvailableRepos::NONE;
+        which_repos_to_load.clear();
         pkg_narrow = PkgNarrow::INSTALLED;
     } else if (extras->get_value()) {
         pkg_narrow = PkgNarrow::EXTRAS;
@@ -125,12 +125,12 @@ void ListCommand::configure() {
     } else if (upgrades->get_value()) {
         pkg_narrow = PkgNarrow::UPGRADES;
     } else if (autoremove->get_value()) {
-        load_available = Context::LoadAvailableRepos::NONE;
+        which_repos_to_load.clear();
         pkg_narrow = PkgNarrow::AUTOREMOVE;
     }
     auto & context = get_context();
-    context.set_load_available_repos(load_available);
-    context.set_load_system_repo(load_system);
+    which_repos_to_load.push_back(libdnf5::repo::Repo::Type::SYSTEM);
+    context.set_load_enabled_repos(which_repos_to_load);
 }
 
 std::unique_ptr<libdnf5::cli::output::PackageListSections> ListCommand::create_output() {

diff --git a/dnf5/commands/makecache/makecache.cpp b/dnf5/commands/makecache/makecache.cpp
@@ -57,8 +57,6 @@ void MakeCacheCommand::run() {
         return;
     }
 
-    ctx.load_repos(false);
-
     std::cout << "Metadata cache created." << std::endl;
 }
 

diff --git a/dnf5/commands/module/module_disable.cpp b/dnf5/commands/module/module_disable.cpp
@@ -50,8 +50,7 @@ void ModuleDisableCommand::set_argument_parser() {
 
 void ModuleDisableCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void ModuleDisableCommand::run() {

diff --git a/dnf5/commands/module/module_enable.cpp b/dnf5/commands/module/module_enable.cpp
@@ -50,8 +50,7 @@ void ModuleEnableCommand::set_argument_parser() {
 
 void ModuleEnableCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void ModuleEnableCommand::run() {

diff --git a/dnf5/commands/module/module_list.cpp b/dnf5/commands/module/module_list.cpp
@@ -41,8 +41,7 @@ void ModuleListCommand::set_argument_parser() {
 
 void ModuleListCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void ModuleListCommand::run() {

diff --git a/dnf5/commands/module/module_reset.cpp b/dnf5/commands/module/module_reset.cpp
@@ -50,8 +50,7 @@ void ModuleResetCommand::set_argument_parser() {
 
 void ModuleResetCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void ModuleResetCommand::run() {

diff --git a/dnf5/commands/provides/provides.cpp b/dnf5/commands/provides/provides.cpp
@@ -61,10 +61,9 @@ void ProvidesCommand::set_argument_parser() {
 
 void ProvidesCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
     context.base.get_config().get_optional_metadata_types_option().add_item(
         libdnf5::Option::Priority::RUNTIME, libdnf5::METADATA_TYPE_FILELISTS);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 std::pair<libdnf5::rpm::PackageQuery, libdnf5::cli::output::ProvidesMatchedBy> ProvidesCommand::filter_spec(

diff --git a/dnf5/commands/reinstall/reinstall.cpp b/dnf5/commands/reinstall/reinstall.cpp
@@ -60,8 +60,7 @@ void ReinstallCommand::set_argument_parser() {
 
 void ReinstallCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE, libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void ReinstallCommand::run() {

diff --git a/dnf5/commands/remove/remove.cpp b/dnf5/commands/remove/remove.cpp
@@ -59,8 +59,7 @@ void RemoveCommand::set_argument_parser() {
 
 void RemoveCommand::configure() {
     auto & context = get_context();
-    context.set_load_system_repo(true);
-    context.set_load_available_repos(Context::LoadAvailableRepos::NONE);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::SYSTEM});
 }
 
 void RemoveCommand::run() {

diff --git a/dnf5/commands/repo/repo_info.cpp b/dnf5/commands/repo/repo_info.cpp
@@ -96,7 +96,7 @@ class RepoInfoWrapper : public libdnf5::cli::output::IRepoInfo {
 
 void RepoInfoCommand::configure() {
     auto & context = get_context();
-    context.set_load_available_repos(Context::LoadAvailableRepos::ENABLED);
+    context.set_load_enabled_repos({libdnf5::repo::Repo::Type::AVAILABLE});
 }
 
 void RepoInfoCommand::print(const libdnf5::repo::RepoQuery & query, [[maybe_unused]] bool with_status) {

diff --git a/dnf5/commands/repoquery/repoquery.cpp b/dnf5/commands/repoquery/repoquery.cpp
@@ -458,10 +458,13 @@ void RepoqueryCommand::configure() {
 
     auto & context = get_context();
     context.update_repo_metadata_from_specs(pkg_specs);
-    system_repo_needed = installed_option->get_value() || userinstalled_option->get_value() ||
-                         duplicates->get_value() || leaves_option->get_value() || unneeded->get_value() ||
-                         extras->get_value() || upgrades->get_value() || installonly->get_value();
-    context.set_load_system_repo(system_repo_needed);
+    std::vector<libdnf5::repo::Repo::Type> which_repos_to_load;
+    bool system_repo_needed = installed_option->get_value() || userinstalled_option->get_value() ||
+                              duplicates->get_value() || leaves_option->get_value() || unneeded->get_value() ||
+                              extras->get_value() || upgrades->get_value() || installonly->get_value();
+    if (system_repo_needed) {
+        which_repos_to_load.push_back(libdnf5::repo::Repo::Type::SYSTEM);
+    }
     context.update_repo_metadata_from_advisory_options(
         advisory_name->get_value(),
         advisory_security->get_value(),
@@ -471,12 +474,14 @@ void RepoqueryCommand::configure() {
         advisory_severity->get_value(),
         advisory_bz->get_value(),
         advisory_cve->get_value());
-    context.set_load_available_repos(
-        // available_option is on by default, to check if user specified it we check priority
-        available_option->get_priority() >= libdnf5::Option::Priority::COMMANDLINE || !system_repo_needed ||
-                extras->get_value() || upgrades->get_value() || !providers_of_option->get_value().empty()
-            ? Context::LoadAvailableRepos::ENABLED
-            : Context::LoadAvailableRepos::NONE);
+
+    // available_option is on by default, to check if user specified it we check priority
+    if (available_option->get_priority() >= libdnf5::Option::Priority::COMMANDLINE || !system_repo_needed ||
+        extras->get_value() || upgrades->get_value() || !providers_of_option->get_value().empty()) {
+        which_repos_to_load.push_back(libdnf5::repo::Repo::Type::AVAILABLE);
+    }
+
+    context.set_load_enabled_repos(which_repos_to_load);
 
     if (srpm->get_value()) {
         context.base.get_repo_sack()->enable_source_repos();
@@ -524,7 +529,7 @@ void RepoqueryCommand::configure() {
 
 void RepoqueryCommand::load_additional_packages() {
     auto & ctx = get_context();
-    if (ctx.get_load_available_repos() != Context::LoadAvailableRepos::NONE) {
+    if (!ctx.get_load_enabled_repos().empty()) {
         for (auto & [path, package] : ctx.base.get_repo_sack()->add_cmdline_packages(pkg_specs)) {
             cmdline_packages.push_back(std::move(package));
         }

diff --git a/dnf5/commands/repoquery/repoquery.hpp b/dnf5/commands/repoquery/repoquery.hpp
@@ -43,8 +43,6 @@ class RepoqueryCommand : public Command {
     void run() override;
 
 private:
-    bool system_repo_needed = false;
-
     libdnf5::OptionBool * available_option{nullptr};
     libdnf5::OptionBool * installed_option{nullptr};
     libdnf5::OptionBool * userinstalled_option{nullptr};
-Original file line number
+Diff line change
@@ Expand Up / @@ -57,8 +57,6 @@ void MakeCacheCommand::run() { @@
             return;
         }
-        ctx.load_repos(false);
         std::cout << "Metadata cache created." << std::endl;
     }
@@ Expand Down @@