Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scenarios for dnf5 #1477

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

glum23
Copy link
Contributor

@glum23 glum23 commented Mar 22, 2024

Various scenarios have been updated for dnf5. Primarily, tests that called (but not directly tested) "repolist" have been selected for this update. However, all scenarios that could be currently updated for dnf5 have been updated (not only those with repolist calls).
All updated tests passed when run directly in behave and via container-test for the latest available dnf5.

@pkratoch pkratoch self-assigned this Mar 22, 2024
@glum23
Copy link
Contributor Author

glum23 commented Mar 22, 2024

Some checks for dnf5daemon failed due to usage of "repo list" instead of "repolist", e.g.

dnf5daemon-client -y --installroot=/tmp/dnf_ci_installroot_67ltmmd7 --releasever=29 --setopt=module_platform_id=platform:f29 --setopt=cachedir=/tmp/dnf_ci_installroot_67ltmmd7/var/cache/dnf repo list
...
Unknown argument "list" for command "repo". Add "--help" for more information about the arguments.

However, "repo list" should be now the preferred variant for dnf5, "repolist" is just for compatibility. Shouldn't dnf5daemon
respect this, too?

@pkratoch
Copy link
Contributor

The dnf5daemon doesn't have command "repo list", but still uses "repolist". This causes a failure of scenarios in "gpg.feature" and "gpg-noeol.feature" when run for dnf5daemon. I filed an issue for this problem: rpm-software-management/dnf5#1339 Until the issue is fixed, the failing tests cannot be modified to "repo list" and I am not even sure if it's a good idea to modify the passing ones, because it will prevent enabling them for dnf5daemon if needed.

@glum23 glum23 force-pushed the work-repolist-affect branch from 472c1df to 09e3f01 Compare March 22, 2024 12:31
@pkratoch
Copy link
Contributor

Thanks!

@pkratoch pkratoch merged commit 82b53bd into rpm-software-management:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants