指定した GitHub Discussion ID に固定コメントを追加する reusable workflow を作成 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masutaka
force-pushed
the
add-discussion-comment-workflow
branch
from
0e997f7 to
8f4dc4b
Compare
masutaka
force-pushed
the
add-discussion-comment-workflow
branch
from
8f4dc4b to
fc808c6
Compare
masutaka
changed the title
MH4GF
approved these changes
Sep 13, 2024
Comment on lines
97
to
99
| console.log('DISCUSSION_ID: %s', DISCUSSION_ID); | ||
| console.log('COMMENT_TEMPLATE_PATH: %s', COMMENT_TEMPLATE_PATH); | ||
| console.log('REPLY_TO_COMMENT_ID: %s', REPLY_TO_COMMENT_ID); |
There was a problem hiding this comment.
この辺りは消し忘れでしょうか？
nits: ログ出力を意図する場合、coreモジュールの core.info() などを使う方が適切そうでした。
https://github.com/actions/toolkit/tree/main/packages/core#logging
There was a problem hiding this comment.
おっと！ 消し忘れです！ 16646f9 で削除しました。
| DISCUSSION_ID: ${{ inputs.discussion_id }} | ||
| COMMENT_TEMPLATE_PATH: ${{ inputs.comment_template_path }} | ||
| REPLY_TO_COMMENT_ID: ${{ inputs.reply_to_comment_id }} | ||
| uses: actions/github-script@v7 |
|
ありがとうございました！ |
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更概要
comment_template_pathで、ファイルパスを指定する動作確認
補足
@TomckySan と話して、下記 PR を私の方でやろうとしました。
ただ、テンプレートファイルで変数を使うのは、初期実装として大きかったので一旦固定コメントにしました。
コメントを何個も追加するユースケースは、matrix 使って add_discussion_comment.yml を何回も実行したほうが良いかも知れません。