pwa support for elastic skin #9354
Conversation
| @@ -39,6 +39,47 @@ | |||
| } catch (e) { } | |||
| </script> | |||
| <roundcube:endif /> | |||
| <roundcube:if condition="env:action != 'print' && !config:devel_mode" /> | |||
| <link rel="manifest" href="/manifest.json"> | |||
There was a problem hiding this comment.
one high-res icon should be enough, also it is much easier to replace it with a custom icon then
There was a problem hiding this comment.
You'd have to discuss this point with the guys that defined PWA I guess 😊
There was a problem hiding this comment.
https://developer.apple.com/design/human-interface-guidelines/app-icons#App-icon-sizes says:
You can let the system automatically scale down your 1024x1024 px app icon to produce all other sizes
For MS Windows and Android, at least 512x512 pixels are required. So to me, too, this sounds like way fewer icons are possible to make it work.
I guess for optimal icon displaying more sizes are better, but for this PR to be mergeable we need to find a solution that keeps changing the icon feasible. (Nothing stops anyone from adding more icons at all.)
@the0ne Would you be willing to change this to reach a possible compromise?
There was a problem hiding this comment.
I'd be really happy if somebody would step in and take care of those changes.
In the next several months (or even longer) I won't be able to take care about this.
|
I don't think I'm gonna accept this. Maybe it should/could become a plugin. People really need a way to replace the icon easily. So, maybe we could generate all icon sizes from a single icon when they are requested. Also things like |
|
Yeah, the application name clearly wasn't meant like this. |
|
|
😂👍🏻 I don't think that's gonna cut it... 😉 Anyway, I've made this PR as a proposal on how this whole feature can easily be implemented. I don't feel you're particularly interested anyway and I don't intend to play a game where you request random changes and expect me to search for solutions in your software. So just let me know and I'll happily cancel the PR if that's your wish. Thanks! 🙂👌🏻 |
|
Will need something like #7709 I think this is a great idea, would love to see it, but the current login flow won't make this an easy thing as you'll be logged out any time the window closes. |
|
Wasn't an issue on the installation I host because anyway I got the 'persistent_login' plugin installed which takes care of this automatically. |
|
|
||
| self.addEventListener( "install", function ( event ) { | ||
|
|
||
| console.log( "Installing the service worker!" ); |
There was a problem hiding this comment.
Please remove the logging from this file (or make it helpful beyond debugging).
There was a problem hiding this comment.
Actually this sets up caching network data, but that data doesn't ever get used, right? So please either complete that feature or remove it.
|
FTR: #9014 is "prior art", but much less elaborate. |
|
|
||
| } ); | ||
|
|
||
| self.addEventListener( "fetch", function ( event ) { |
There was a problem hiding this comment.
Roundcube doesn't use fetch in most of its code (it's older code that uses XMLHttpRequest), so this won't actually do anything.
|
IMO the service worker should be removed from this PR and done in a separate one. Offline access is a major feature of PWAs, but it'd be non-trivial to implement. Adding the metadata and icon would be beneficial. Maybe this could be split into three PRs:
|
|
Since the original author stated that he(?) won't work on this further and no one stepped up, I'll close this. If anyone is interested to resume working on it, please reopen. |
|
Why would you close this? You only have a few remarks, but to solve those I'd have to learn soooo much about all the internals of RC.
I really don't get why you'd close this PR - is this about "statistics only" for you? |
|
It's not at all about statistics, it's about reducing the mental load of open threads. Having too many open pull requests that no one is working on drowns other PRs that would need the attention, I feel. Thus I closed it with the explicit remark that it can be re-opened – if someone steps up to work on it. I don't quite understand if you want to work on it but just need better feedback than before, or if you just think someone else should do it. In the former case, please let me know, I'd be happy to re-open and help! |
|
Hi @pabzm if I understood the above right, it's about few things only:
It's clear that it would take very much effort for me to learn about all the internals of RC whereas the actual implementation would probably take only a few hours. |
|
@the0ne Well you convinced me that you do care about this feature, so I'll re-open even if it's unclear who's going to work on this :) |
As progressive web app support is great nowadays on all major operating system platforms, roundcube can be used even more convenient if it supports this standard. Roundcube can look like it was installed as a 'real' app, have a proper launcher icon, etc.
Even notifications would be possible if the service worker inside sw.js is further enhanced in the future.
This PR should solve #6510.