Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update roughjs to 4.5.2 #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): Update roughjs to 4.5.2 #188

wants to merge 1 commit into from

Conversation

kasbah
Copy link

@kasbah kasbah commented Jan 22, 2023

fixes #179

  • Remove and ignore the package-lock.json (since this is a library and the library consumers don't get to use the lock -- better to know ASAP if it's broken without the lock)
  • Set version to ~4.5.2 with a squiggle, since roughjs doesn't seem to be following sem-ver (broke the API on a minor version bump)
  • Use the new function fillPolygons

@kasbah kasbah changed the title Update roughjs to 4.5.2 chore(deps): Update roughjs to 4.5.2 Jan 22, 2023
@kasbah kasbah force-pushed the fix-fill-polygons branch from a0f930f to dcb60a8 Compare January 22, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfriend nfriend nfriend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: getting hf.fillPolygon is not a function error
2 participants
@kasbah @nfriend