Update to .NET 8 #119
Update to .NET 8 #119
Conversation
* otherwise the logo and readme are not found
* to fix the error: One or more duplicate file names were detected. All image output filenames must be unique.
* Cannot resolve property "SelectedTabTextColor" on type "MaterialUnderlinedTabItem (property missing or missing accessors)".
|
Too bad there is no CI here to verify the build ... (I could contribute some hooks for GitHub Actions, if this is desired.) |
|
Thank you for your proposal, I sent you an invite |
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| <Style x:Key="MaterialTabStyle" TargetType="tabs:MaterialUnderlinedTabItem"> | |||
| <Setter Property="SelectedTabColor" Value="{StaticResource Primary}" /> | |||
| <Setter Property="SelectedTabTextColor" Value="{StaticResource Secondary}" /> | |||
| <!--<Setter Property="SelectedTabTextColor" Value="{StaticResource Secondary}" />--> | |||
There was a problem hiding this comment.
To fix a build error:
Cannot resolve property "SelectedTabTextColor"
on type "MaterialUnderlinedTabItem
(property missing or missing accessors)".
There was a problem hiding this comment.
AFAICS the error message is correct, right? SelectedTabTextColor is only available in BottomTabItem, but not in MaterialUnderlinedTabItem (both inherit from TabTextItem, directly or indirectly).
Not sure why this was missed with net6.0. Probably improved diagnostics in net8.0, I guess ...
See |
|
Thank you so much for this PR ! |
|
I guess it fixes #116 right ? |
Thanks for merging!
I'm not sure (have not tried it with .NET 9 yet). It sounds like #116 is caused by references to obsoleted code ( Since @daltzctr Could you please check if this PR fixes #116 for you? |
This PR updates Maui.Tabs and MauiSample from .NET 6 to .NET 8 (since .NET MAUI 6 is out of support by now). It fixes all errors I encountered in the process (and a few obsolescence warnings).
It enables me to build the sample again, thereby fixing #115.
IMHO it is also a first step that should be taken before targeting .NET 9, as proposed in #118.