-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: guide for token detection #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LefterisJP
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't write one sentence per line without .
in markdown.
LefterisJP
reviewed
Nov 20, 2024
cleanerzkp
force-pushed
the
docs/redetect-tokens
branch
from
November 21, 2024 08:43
1ef14a6
to
60b80d4
Compare
LefterisJP
reviewed
Nov 21, 2024
cleanerzkp
force-pushed
the
docs/redetect-tokens
branch
from
November 21, 2024 08:58
60b80d4
to
f315ff6
Compare
LefterisJP
reviewed
Nov 21, 2024
docs: testing UI library in the app docs: improve token detection guide per comments docs: finalize token detection guide
cleanerzkp
force-pushed
the
docs/redetect-tokens
branch
from
November 21, 2024 09:49
f315ff6
to
add2cb0
Compare
LefterisJP
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added guide for testing ui-library changes in rotki main repo (2nd commit)