Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param manager not error checking double params appropriately. #70

Open
JMoore5353 opened this issue Jul 26, 2024 · 0 comments
Open

Param manager not error checking double params appropriately. #70

JMoore5353 opened this issue Jul 26, 2024 · 0 comments
Assignees

Comments

@JMoore5353
Copy link
Contributor

When checking for errors in the parameter manager, the get_double method does not handle errors appropriately. This is because when a std::variant gets created, it defaults to the first templated type listed. Since double is listed first, it initializes double parameters to zero instead of returning an error when accessing a parameter not previously declared.

@JMoore5353 JMoore5353 self-assigned this Jul 26, 2024
@amysea123 amysea123 reopened this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants