You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rosflight_io node currently saturates the PASSTHROUGH commands that it receives from the /command topic. This should be changed, since "passthrough" should mean passing commands directly to the mixer. In some cases the commands will be within the saturation ranges currently in the rosflight_io node, but often they will not be (i.e., sending thrust to the mixer instead of throttle).
Saturation should also happen where it makes sense... I think it should be the responsibility of the user to saturate their data being sent to the /command topic. Putting it in the "I/O" node makes less sense to me.
@iandareid@bsutherland333 Do you have any opinions on if this should be kept in the rosflight_io node?
The text was updated successfully, but these errors were encountered:
The
rosflight_io
node currently saturates thePASSTHROUGH
commands that it receives from the/command
topic. This should be changed, since "passthrough" should mean passing commands directly to the mixer. In some cases the commands will be within the saturation ranges currently in therosflight_io
node, but often they will not be (i.e., sending thrust to the mixer instead of throttle).Saturation should also happen where it makes sense... I think it should be the responsibility of the user to saturate their data being sent to the
/command
topic. Putting it in the "I/O" node makes less sense to me.@iandareid @bsutherland333 Do you have any opinions on if this should be kept in the
rosflight_io
node?The text was updated successfully, but these errors were encountered: