Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROSflight_io node saturates passthrough input #187

Closed
JMoore5353 opened this issue Aug 28, 2024 · 0 comments · Fixed by #188
Closed

ROSflight_io node saturates passthrough input #187

JMoore5353 opened this issue Aug 28, 2024 · 0 comments · Fixed by #188

Comments

@JMoore5353
Copy link
Contributor

JMoore5353 commented Aug 28, 2024

The rosflight_io node currently saturates the PASSTHROUGH commands that it receives from the /command topic. This should be changed, since "passthrough" should mean passing commands directly to the mixer. In some cases the commands will be within the saturation ranges currently in the rosflight_io node, but often they will not be (i.e., sending thrust to the mixer instead of throttle).

Saturation should also happen where it makes sense... I think it should be the responsibility of the user to saturate their data being sent to the /command topic. Putting it in the "I/O" node makes less sense to me.

@iandareid @bsutherland333 Do you have any opinions on if this should be kept in the rosflight_io node?

@JMoore5353 JMoore5353 linked a pull request Aug 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant