fix(StaticSingleThreadedExecutor): Fixed regression in spin() #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmachowinski
force-pushed
the
static_executor_fix
branch
from
242a37a
to
eb38015
Compare
jmachowinski
changed the title
alsora
requested changes
Apr 2, 2024
rclcpp/src/rclcpp/executors/static_single_threaded_executor.cpp
Outdated
Show resolved
Hide resolved
jmachowinski
force-pushed
the
static_executor_fix
branch
from
eb38015
to
bb36ebb
Compare
alsora
reviewed
Apr 2, 2024
fujitatomoya
reviewed
Apr 2, 2024
There was a problem hiding this comment.
this fix itself lgtm, the most efficient way to execute the executables.
i also would like to know https://github.com/ros2/rclcpp/pull/2473/files#r1548256408 from @alsora before green light.
Merging with green CI |
Signed-off-by: Janosch Machowinski <[email protected]>
jmachowinski
force-pushed
the
static_executor_fix
branch
from
bb36ebb
to
ddbe473
Compare
|
rebased to rolling. As this is a pure bug fix, whats the process for merging this, wait until unfreeze, rolling and backport to jazzy ? |
Yep, that's exactly correct. |
|
|
@jmachowinski friendly ping. What would you like to do with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2470