Skip to content

Commit

Permalink
rmw_fastrtps supports service event gid uniqueness test. (#2638)
Browse files Browse the repository at this point in the history
Signed-off-by: Tomoya Fujita <[email protected]>
  • Loading branch information
fujitatomoya authored Oct 14, 2024
1 parent 41d3a27 commit 0be8aa0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions rclcpp/test/rclcpp/test_service_introspection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ TEST_F(TestServiceIntrospection, service_introspection_nominal)
ASSERT_THAT(
client_gid_arr,
testing::Eq(event_map[ServiceEventInfo::REQUEST_SENT]->info.client_gid));
// TODO(@fujitatomoya): Remove this if statement once other rmw implementations support test.
// Only rmw_connextdds can pass this test requirement for now.
// TODO(@fujitatomoya): Remove this if statement once rmw implementations support test.
// rmw_cyclonedds_cpp does not pass this test requirement for now.
// See more details for https://github.com/ros2/rmw/issues/357
if (std::string(rmw_get_implementation_identifier()).find("rmw_connextdds") == 0) {
if (std::string(rmw_get_implementation_identifier()).find("rmw_cyclonedds_cpp") != 0) {
ASSERT_THAT(
client_gid_arr,
testing::Eq(event_map[ServiceEventInfo::REQUEST_RECEIVED]->info.client_gid));
Expand Down

0 comments on commit 0be8aa0

Please sign in to comment.