-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Display Type Vector3Stamped #860
base: groovy-devel
Are you sure you want to change the base?
Conversation
I wonder if this is related: #811 |
Thanks for the contribution, but as I said in the other issue, I won't be releasing new versions of Groovy. I'd be happy to consider taking this on the |
I'll make a new pull request against indigo once I install it somewhere so that I can make sure it runs. Thanks! |
Hi @DaikiMaekawa sorry, I never took the time to get ROS indigo running. There are 4 commits in this PR. I don't know what the merge commits are, they might have been a mistake. However, if you apply the two top commits, you should get the Vector3 code working. You'll need this commit: goretkin@509503d and its parent. If you can confirm that it's working on Indigo, it would be great if you could make a PR to Indigo! The question still remains on how to do this without duplication. There should probably be some base code to visualize vectorial quantities, with properties such as scale and color. Then Wrench, Twist, and Vector3 would all rely on that. |
I am writing this on top of Groovy, but aside from the changes in c7b8d44, it should apply to more recent releases.
This is essentially a duplicate of the Wrench code. If I had to visualize a Twist, it would be exactly the Wrench code. Is there a way to avoid this duplication?
Visualizing Wrenches worked fine for me, but for visualizing Vector3, for one iteration
scale_
was NaN, which triggers an Ogre assertion error. I don't know why this happens and why it's different behavior from the Wrench code, but for now I check for NaN.